New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to CancellationToken, Use spawn instead of exec, Add output channel for logging #147

Merged

Sija merged 18 commits into crystal-ameba:master from nobodywasishere:nobody/spawn-and-cancellation

Nov 27, 2024

Contributor

nobodywasishere commented Nov 24, 2024 •

edited

Loading

Part 1 of split up of PR #145

Only prints logs for valid files

nobodywasishere mentioned this pull request

Add lint on type #148

Closed

Sija requested changes

View reviewed changes

src/extension.ts Outdated Show resolved Hide resolved

src/extension.ts Outdated Show resolved Hide resolved


          Use spawn instead of exec for invoking ameba

5a5f8c2

Refactor Task{Queue,} to use vscode's CancellationToken
Add output channel for logging state of extension

nobodywasishere force-pushed the nobody/spawn-and-cancellation branch from 1ea892d to 5a5f8c2 Compare

November 24, 2024 17:55

nobodywasishere mentioned this pull request

Reload diagnostics when changing vscode/local config #150

Merged

Sija requested changes

View reviewed changes

src/ameba.ts Show resolved Hide resolved

src/ameba.ts Outdated Show resolved Hide resolved

src/ameba.ts Outdated Show resolved Hide resolved

src/ameba.ts Outdated Show resolved Hide resolved

src/extension.ts Outdated Show resolved Hide resolved

src/taskQueue.ts Outdated Show resolved Hide resolved

nobodywasishere and others added 5 commits

November 24, 2024 13:49


          Update src/ameba.ts

ebaa03a

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>


          Update src/ameba.ts

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>


          Update src/ameba.ts

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>


          Update src/ameba.ts

7a3d2f2

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>


          Update src/taskQueue.ts

b7fcaa0

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

Sija reviewed

View reviewed changes

src/taskQueue.ts Outdated Show resolved Hide resolved


          Update src/taskQueue.ts

73cf570

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

Sija reviewed

View reviewed changes

src/extension.ts Outdated Show resolved Hide resolved


          Update src/extension.ts

4fa2e4f

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

Sija reviewed

View reviewed changes

src/ameba.ts Show resolved Hide resolved

nobodywasishere and others added 2 commits

November 24, 2024 14:04


          Formatting

a1d4fbe


          Update src/ameba.ts

d50273a

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

Sija reviewed

View reviewed changes

src/ameba.ts Outdated Show resolved Hide resolved

Sija reviewed

View reviewed changes

src/ameba.ts Outdated Show resolved Hide resolved

Sija reviewed

View reviewed changes

src/ameba.ts Outdated Show resolved Hide resolved

nobodywasishere and others added 3 commits

November 24, 2024 14:12


          Update src/ameba.ts

86fdaf0

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>


          Update src/ameba.ts

6bac44c

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>


          Update src/ameba.ts

7d837e9

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

Sija reviewed

View reviewed changes

src/extension.ts Outdated Show resolved Hide resolved

Contributor Author

nobodywasishere commented Nov 24, 2024 •

edited

Loading

I don't have tslint setup (as it's deprecated, see discussion to move to eslint), otherwise a lot of the minor changes could be automatically fixed while typing.


          Apply suggestions from code review

68e714e

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

Sija reviewed

View reviewed changes

src/extension.ts Outdated Show resolved Hide resolved


          Update src/extension.ts

a432c7e

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>

Sija reviewed

View reviewed changes

src/extension.ts Outdated Show resolved Hide resolved

Sija approved these changes

View reviewed changes

Member

Sija left a comment

LGTM 🚀

Sija requested a review from veelenga

November 24, 2024 19:27

veelenga reviewed

View reviewed changes

src/ameba.ts Show resolved Hide resolved

src/extension.ts Outdated Show resolved Hide resolved

src/extension.ts Outdated Show resolved Hide resolved


          Add output channel to context subscriptions, helper method for valid …

…saved documents

veelenga approved these changes

View reviewed changes

Member

veelenga left a comment •

edited

Loading

LGTM. Thank you ❤️

Sija reviewed

View reviewed changes

src/extension.ts Outdated Show resolved Hide resolved

nobodywasishere and others added 2 commits

November 27, 2024 18:12


          Update extension.ts

d8c992b

Co-authored-by: Sijawusz Pur Rahnama <[email protected]>


          Fix error

e39c50e

Sija merged commit 8883673 into crystal-ameba:master

2 checks passed

nobodywasishere deleted the nobody/spawn-and-cancellation branch

November 28, 2024 01:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet