Add support for linting while typing

[nobodywasishere]

• Adds settings crystal-ameba.lint-trigger:
  • none: linting will always be triggered automatically by commands
  • save: linting is only triggered when saving
  • type: linting is run for the current file every time there's a change
• Defaults to type unless ameba is < 1.6.4

Resolves #89

[Sija]

Aside of my other comments, I'm wondering is this change really needed?

[nobodywasishere]

Yes? This was the entire purpose of me creating this series of PRs (and adding stdin support to ameba), to allow for running the ameba linter while typing, which significantly improves the development experience.

[Sija]

@nobodywasishere My bad, I was unclear (writing on mobile...), what I really meant to ask was: why switching to enum instead of multiple choice is needed?

[nobodywasishere]

Ahh okay. In my opinion, having the enum is much clearer about what is happening. Having both an "on type" and "on save" setting may get confusing, especially since there's no way to support the case of "on save" being false and "on type" being true.

[Sija]

I've checked other, similar-type-of extensions and they're doing the same thing (enum), so it seems that's just the way the cookie crumbles.

[Sija]

There are some errors that needs fixing, otherwise seems GTG.