-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console.log
go brrr
#193
Merged
Merged
console.log
go brrr
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xenomega
approved these changes
Aug 15, 2023
damilolaedwards
pushed a commit
that referenced
this pull request
Nov 16, 2023
Introduce `console.log` functionality with string formatting capabilities. --------- Co-authored-by: David Pokora <[email protected]>
s4nsec
pushed a commit
that referenced
this pull request
Jul 9, 2024
Introduce `console.log` functionality with string formatting capabilities. --------- Co-authored-by: David Pokora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
console.log
functionality for medusa. The PR must satisfy the following technical requirements:Technical Requirements
console.log
functionality (string formatting is different)console.log
should lead to no performance hits or excessive memory costsDesign
The
console
contract is now aCheatCodeContract
, aka a precompiled contract. Callingconsole.log(x)
will invoke the associated ABI method in the precompile. The method itself actually does nothing! The reason why we can do this is because our execution tracer will be able to track that the console.log precompile was called and it has access to the input arguments provided to the function. The input arguments is really all we need to handle the rest of the functionality needed by this PR.During the creation of an execution trace, medusa will specifically search for calls to
console.log
and will then attempt to parse the various inputs. The main thing that needs to happen with inputs is (a) string formatting or (b) encoding the ABI values into a string. Option (b) is trivial and was already supported. medusa will gather all the logs found in an execution trace and append it to the bottom of the trace under[Logs]
.String formatting
The
console.log
PR also supports string formatting. Note the string formatting is effectivelyfmt.Sprintf(formattedString, args)
. Since we use golang's default string formatter, we do not fully support foundry'sconsole.log
string formatting. Identifiers such as%o
or%i
do not work in golang. Thus, the associated documentation for our PR should highlight these differences.