Fix testAllContracts behavior
#253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xenomega
approved these changes
Nov 8, 2023
This was referenced Nov 8, 2023
damilolaedwards
added a commit
that referenced
this pull request
Dec 28, 2023
Leeyah-123
pushed a commit
to Leeyah-123/medusa
that referenced
this pull request
Jun 4, 2024
s4nsec
pushed a commit
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
testAllContractswill try to fuzz test dynamically deployed contracts (e.g.a = new Contract()). This is a deviation from how echidna works and also complicates the fuzzing processes (also slows it down a lot for complex systems).This PR aims to prevent this by tracking dynamic deployments in the test chain deployments tracer and ensuring that the fuzzer worker does not add the contract to its working set if
testAllContractsisfalseand the contract is a dynamic deployment.Additionally,
stopOnFailedContractMatchingis now defaulted tofalseto improve UX - this is an advanced feature that you should toggle on-purpose.This PR closes the following:
#250
#244