Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Coverage report improvements #302

Merged
merged 5 commits into from
Feb 4, 2025
Merged

Conversation

Xenomega
Copy link
Member

@Xenomega Xenomega commented Feb 20, 2024

This PR adds buttons to "expand all", "collapse all", "expand empty", and "collapse empty" contracts in our coverage reports.

It also simplifies some of the surrounding code.

Expand/collapse all is OK, but it seems like we need better navigatability. Outstanding tasks are:

  • Add a file explorer on the left (similar to GitHub's split pane view for changed files. Needs support to click + jump to a file (should auto expand).
  • Add some kind of headings so when you click a file in the explorer, it adds the heading to the page URL (so you can reference it later).
  • Add auto-expand to the panels when a selection is made within them. Specifically, if you search for a word like "function" with all source files collapsed, it will show you results but not bring you to them, because the collapsible containers do not expand.

@Xenomega Xenomega requested a review from anishnaik as a code owner February 20, 2024 20:36
Copy link
Collaborator

@anishnaik anishnaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bing bong

@anishnaik anishnaik changed the title [WIP] Coverage report improvements HTML Coverage report improvements Feb 4, 2025
@anishnaik anishnaik removed the request for review from bsamuels453 February 4, 2025 14:34
@anishnaik anishnaik merged commit c227b2c into master Feb 4, 2025
12 checks passed
@anishnaik anishnaik deleted the dev/coverage-collapsibility branch February 4, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants