fix(action): output checklist #81
Conversation
Slither implies that the GitHub Action supports checklist output: ```console Checklist (consider using https://github.com/crytic/slither-action): --checklist Generate a markdown page with the detector results --checklist-limit CHECKLIST_LIMIT Limit the number of results per detector in the markdown file --markdown-root MARKDOWN_ROOT URL for markdown generation ``` This PR does not implement checklist explicitly, as you can already get it by passing in the additional arguments option. Adding the needed definition in the `entrypoint.sh` script would be explicit.
There was a problem hiding this comment.
Hi @sambacha! The action has no checklist output property, and this PR does not implement one either, so this PR is not correct as-is. The outputs section of action.yml should only have output variables -- i.e. variables that we add to $GITHUB_OUTPUT, like sarif and stdout.
We have an example of how to use the checklist functionality on our README if you're interested in using it: https://github.com/crytic/slither-action?tab=readme-ov-file#example-workflow-markdown-report
Thank you for referring to the example. I came across this issue again and fixed it here crytic/slither#2513 I actually find the SARIF output with the ToB VSCode Extension much more useful! Thank you for following up, much appreciated! |
Slither implies that the GitHub Action supports checklist output:
This PR does not implement checklist explicitly, as you can already get it by passing in the additional arguments option.
Adding the needed definition in the
entrypoint.shscript would be explicit.