Fix arbitrary_cpi lint and add documentation to it #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR does not change much: The PR moves the code finding the alias of program_id to a separate function. |
smoelius
reviewed
Feb 5, 2024
There was a problem hiding this comment.
I have just a couple nits. This PR introduces commented code, which appears to be incomplete, e.g.:
// println!("5. {:?}, {:?}", stmt, stmt.kind);
// println!("2. {:?}, {:?}, {:?}", assign_place, inst_arg, rvalue);
// println!("4. {:?}", inst_arg);
// println!("x. {:?}", pl);
lints/arbitrary_cpi/src/lib.rs
Outdated
| /// - If one of the arg accesses `program_id`, check if the basic block containing the comparison | ||
| /// dominates the basic block containing call to `invoke` ensuring the `program_id` is checked in all execution | ||
| /// paths. | ||
| /// - If basic block does not dominate or there is no such comparison report the call to `invoke` |
There was a problem hiding this comment.
No, the sentence is complete. Is anything not clear?
S3v3ru5
force-pushed
the
fix-arbitrary-cpi
branch
from
9688681
to
4113122
Compare
|
I have clarified documentation and update the PR. I have also updated to follow the "caller" to "callee" topological order for functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
arbitrary_cpilint implementation had an incorrect match statement of which one of arm is never executed. The lint is updated to fix that.The PR also
How the lint is implementeddocumentation for the lint.