Fixing Open Issues #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CP and UDP headers
ashmchiu
reviewed
Jan 25, 2024
There was a problem hiding this comment.
Need to actually see the changes in rich text/deploy (and @brandonlouie will confirm dark mode later), but so far looks good.
Mostly deals with a lot of typos and a few rewordings. Tables are now better.
Waiting to approve just to see if I can locally deploy the branch.
brandonlouie
approved these changes
Jan 25, 2024
Closed
peyrin
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top: Changed the Encryption/Decryption diagrams so it should be easier to see when in dark mode.
Fixed: #43
which is also this issue: #37
Fixed: #42
Fixed: #41
Fixed: #40
Fixed: #27
Fixed: #29
make it easier to see in dark mode with chapter 18
Fixed: #17
made new diagrams