187434306 set up flow to create extension #46
Conversation
…et-up-flow-to-create-extension commit okay.
There was a problem hiding this comment.
Nit: we already have a gem for mocking out http requests. You can see my test file for the facade to see how that's done.
There was a problem hiding this comment.
Don't include your .DS_Store. It should also be in your .gitignore
There was a problem hiding this comment.
Nit: Ideally avoid including comments for things you plan on doing in the future -- the correct place for that is on the tracker as a separate ticket.
| def destroy | ||
| render :json => 'not yet implemented'.to_json, status: 501 | ||
| render body: 'The index method of CoursesController is not yet implemented'.to_json, status: 501 |
There was a problem hiding this comment.
Nit: try to stay within convention for how we're handling unimplemented routes. We have a standard response payload.
There was a problem hiding this comment.
For all of these, we should use standard (updated) ruby syntax for hashes (use : instead of =>
| end | ||
|
|
||
|
|
||
| #TODO: Test get/delete |
There was a problem hiding this comment.
Same thing as before with the commented code / todo
|
Included in #47 with necessary fixes. |
General Info
Changes
Explain your changes here (in such a way that you would understand why you made them a year from now).
Set up the flow for creating extension along with rspec test coverage,
Testing
Explain how you tested your changes. If testing is not necessary, explain why.
Tested the changes:
spec/controllers/api/v1/extensions_controller_spec.rb
Documentation
Does this PR require documentation. If so, explain where it can be found.
Documentation is in the group meeting documentation google doc.
Checklist