-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate reva configuration from Helm Values #48
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mirekys very nice idea behind this PR, I love it!
However, I think as both a backwards-compatibility mechanism and to provide some flexibility in terms of being able to inject the .toml
file directly (e.g. when migrating from existing non-kubernetes reva installations), it could be good to keep this logic as well as fallback.
For instance, when passing a file rather than individual config parameters - cc/ @labkode we discussed this a couple of years ago, what do you think?
Hi @SamuAlfageme, this change is already backwards-compatible. If someone wishes to inject toml file as a reva config, |
@dagl please review |
This PR allows chart users to modify individual settings of Reva daemon directly either
by Helm
values.yaml
or byhelm upgrade ... --set config.some-reva-setting=value
method, ratherthan by rewriting the whole
revad.toml
file. It also allows for inheritance of common Reva settings in subcharts,leveraging built-in Helm values inheritance.
Currently used way of configuring Reva using static toml files:
remains still possible.
Contributing a Chart / update to an existing Chart
helm lint
on the chart dir.Chart.yaml
version before merging, to release it as a new version.annotations
on theChart.yaml
with:artifacthub.io/changes
- the changes introduced on the PR with the appropiate format.artifacthub.io/images
- the updated tag on thecs3org/revad
image.values.yaml
. Add documentation in the appropiate README.