Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make implementation fully Microsoft-compliant #76

Open
8 of 14 tasks
glpatcern opened this issue May 3, 2022 · 3 comments
Open
8 of 14 tasks

Make implementation fully Microsoft-compliant #76

glpatcern opened this issue May 3, 2022 · 3 comments

Comments

@glpatcern
Copy link
Member

glpatcern commented May 3, 2022

The Microsoft 365 cloud services provide since long time an up-to-date, GUI-based WOPI validation test suite. Most tests pass or are skipped because of missing capabilities, but a few fail and should be fixed.

In particular:

  • CheckFileInfoSchema.HostUrls -> addressed by Enable compliant host URLs in CheckFileInfo #93
  • FileVersion -> addressed by Use the etag for WOPI versions #62
  • PutUserInfo
  • PutRelativeFile.RelativeNameConflictOverwriteFalse
  • PutRelativeFile.FileNameLongerThan512Chars
  • PutRelativeFile.IncludeHostUrls
  • PutRelativeAndRenameFile.RenameShouldSucceed
  • PutRelativeAndRenameFile.FileNameAfterRenameIsCorrectlyEncoded
  • PutRelativeAndRenameFile.RenamingALockedFileWithACorrectLockHeaderValueShouldSucceed
  • PutRelativeAndRenameFile.RenameShouldNotChangeFileExtension
  • FileUrlUsage
  • ProofKeys.CurrentInvalid.OldValidSignedWithOldKey
  • ProofKeys.CurrentInvalid.OldInvalid
  • ProofKeys.TimestampOlderThan20Min
@glpatcern
Copy link
Member Author

This is the current state with version 8.2.0 and after enabling renames:
image

The 4 failing tests with rename operations are all due to the same issue, that is the wopiserver is largely based on filenames for its operations and should use the fileid instead.

@glpatcern
Copy link
Member Author

Current state of the test suite with rename operations disabled:

image

@glpatcern
Copy link
Member Author

As part of the tests for #94, some broken cases were found and fixed on single-file shares, which after #97 cannot execute PutRelative and would trigger the PutRelativeUnsupported group of tests. This is now fixed:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant