Enable compliant host URLs in CheckFileInfo #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 8bdcf31 into 3a14937 - view on LGTM.com new alerts:
|
14 tasks
glpatcern
force-pushed
the
hosturls
branch
3 times, most recently
from
3625085
to
cb6af97
Compare
This implied adding the original fileid to the WOPI access token, and altering the internal format of inodes to be compatible with the web frontend.
…nd made it part of the configuration
javfg
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, on
CheckFileInfowe return the app URLs themselves asHostViewUrlandHostEditUrl, which is suboptimal when using the "Save As" feature or when there's a reload, as the user is redirected outside of the standard (ownCloud web) iframe.This PR introduces the possibility to configure those URLs, which would be used by OCIS and Reva (not usable by the legacy CERNBox UI instead), as they have a dedicated route to open files in apps.
This allows to pass one more test in #76