This repository has been archived by the owner on Apr 11, 2018. It is now read-only.
Enabled Secure Cookies, cookies sent only when HTTPS is present #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised that the csesoc website didn't have the "secure" flag on the session token it was issuing. I added it in the django settings, however have not tried or checked if my changes are actually working.
Before accepting this pull request, I'd suggest that someone tests that the setting that I just added, does indeed add the "secure" flag to the session cookie when logged in, and also does not break site functionality
Thanks!
In future, I will be testing if my changes are functional, but for the time being, I thought I'd just push this out.