Merge pull request #196 from csinva/resid_calc_comments

Add comment about residuals
csinva · Dec 30, 2023 · 6efaa90 · 6efaa90
2 parents 329f6ea + 2119158
commit 6efaa90
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/imodels/tree/figs.py b/imodels/tree/figs.py
@@ -352,6 +352,8 @@ def fit(
                 y_residuals_per_tree[tree_num_] = deepcopy(y)
 
                 # subtract predictions of all other trees
+                # Since the current tree makes a constant prediction over the node being split,
+                # one may ignore its contributions to the residuals without affecting the impurity decrease.
                 for tree_num_other_ in range(len(self.trees_)):
                     if not tree_num_other_ == tree_num_:
                         y_residuals_per_tree[tree_num_] -= y_predictions_per_tree[