Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSS notebook #12

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

TSS notebook #12

wants to merge 5 commits into from

Conversation

eric542
Copy link
Contributor

@eric542 eric542 commented Jul 22, 2022

Adding case-studies notebook about measuring TSS from Sentinel-2 data in Lake Tempe. Had to update the 'datacube_utils.py' script with a new function. Also included the shape file of Lake Tempe boundary in a sub-folder (ancillary_data) - not sure this is the best way of providing this shape file to the user (via geoserver better perhaps...?).

Fixes #11

This branch can be deleted after merging.

@eric542 eric542 added the enhancement New feature or request label Jul 22, 2022
@eric542 eric542 requested review from mpaget and rtaib July 22, 2022 01:21
@eric542 eric542 linked an issue Jul 22, 2022 that may be closed by this pull request
case-studies/measuring_TSS_in_Lake_Tempe.ipynb Outdated Show resolved Hide resolved
case-studies/measuring_TSS_in_Lake_Tempe.ipynb Outdated Show resolved Hide resolved
case-studies/measuring_TSS_in_Lake_Tempe.ipynb Outdated Show resolved Hide resolved
case-studies/measuring_TSS_in_Lake_Tempe.ipynb Outdated Show resolved Hide resolved
case-studies/measuring_TSS_in_Lake_Tempe.ipynb Outdated Show resolved Hide resolved
case-studies/measuring_TSS_in_Lake_Tempe.ipynb Outdated Show resolved Hide resolved
case-studies/measuring_TSS_in_Lake_Tempe.ipynb Outdated Show resolved Hide resolved
case-studies/measuring_TSS_in_Lake_Tempe.ipynb Outdated Show resolved Hide resolved
@rtaib
Copy link
Contributor

rtaib commented Jul 22, 2022

Looks like you will address all my points in your next commit (not done yet as far as I can tell). I'm happy to approve then.

@eric542 eric542 requested a review from rtaib July 24, 2022 21:51
@eric542
Copy link
Contributor Author

eric542 commented Jul 24, 2022

@rtaib Pushed a new commit with changes addressing your PR review, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create TSS notebook
2 participants