lint: fix failing eslint rules

csound · Sep 14, 2024 · 04f8322 · 04f8322
1 parent 8f8ac7f
commit 04f8322
Show file tree

Hide file tree

Showing 22 changed files with 139 additions and 135 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -1,15 +1,34 @@
 import eslint from "@eslint/js";
 import tseslint from "typescript-eslint";
+import globals from "globals";
+import eslintPluginUnicorn from "eslint-plugin-unicorn";
+import eslintPluginReactHooks from "eslint-plugin-react-hooks";
 
 export default tseslint.config(
     eslint.configs.recommended,
     ...tseslint.configs.recommended,
     {
+        languageOptions: {
+            globals: { ...globals.builtin, ...globals.browser }
+        },
         ignores: ["config/*", "scripts/*", "public/*", "*.test.tsx"],
 
         rules: {
             "@typescript-eslint/no-unused-vars": "off",
-            "@typescript-eslint/no-explicit-any": "off"
+            "@typescript-eslint/no-explicit-any": "off",
+            "@typescript-eslint/no-unused-expressions": "off",
+            "no-empty": "off",
+            "unicorn/no-reduce": "off",
+            "unicorn/no-array-for-each": "off",
+            "unicorn/no-array-reduce": "off",
+            "unicorn/no-array-callback-reference": "off",
+            "unicorn/no-useless-undefined": "off",
+            "unicorn/prevent-abbreviations": "off",
+            "unicorn/no-abusive-eslint-disable": "off"
+        },
+        plugins: {
+            "react-hooks": eslintPluginReactHooks,
+            unicorn: eslintPluginUnicorn
         }
     }
 );
diff --git a/package.json b/package.json
@@ -86,7 +86,7 @@
         "@types/eslint__js": "^8.42.3",
         "@types/jest": "^29.5.13",
         "@types/lodash": "^4.17.7",
-        "@types/ramda": "types/npm-ramda",
+        "@types/ramda": "^0.30.2",
         "@types/react": "^18.3.5",
         "@types/react-dom": "^18.3.0",
         "@types/react-onclickoutside": "^6.7.10",
@@ -129,6 +129,7 @@
         "firebase": "^10.13.1",
         "fork-ts-checker-webpack-plugin": "^9.0.2",
         "fuse.js": "^7.0.0",
+        "globals": "^15.9.0",
         "hex-rgb": "^5.0.0",
         "html-webpack-plugin": "5.6.0",
         "husky": "^9.1.6",

diff --git a/src/components/bottom-tabs/mobile-tabs.tsx b/src/components/bottom-tabs/mobile-tabs.tsx
@@ -70,10 +70,10 @@ const MobileTabs = ({
                           />
                       )
                     : mobileTabIndex === 1
-                    ? MobileFileTree
-                    : mobileTabIndex === 3
-                    ? MobileManual
-                    : undefined}
+                      ? MobileFileTree
+                      : mobileTabIndex === 3
+                        ? MobileManual
+                        : undefined}
                 <MobileNavigation
                     mobileTabIndex={mobileTabIndex}
                     setMobileTabIndex={setMobileTabIndex}

diff --git a/src/components/csound/render-modal.tsx b/src/components/csound/render-modal.tsx
@@ -55,7 +55,7 @@ function fixLeadingSlash(filename) {
 }
 
 function FileTypeIcon({ filename }) {
-    const basename = last(filename.split("/"));
+    const basename = last(filename.split("/")) || "";
     if (basename.endsWith(".csd")) {
         return (
             <span className="rendered-csd-icon">
@@ -266,7 +266,6 @@ function AudioPlayer({
                                 "timeupdate",
                                 onAudioProgress
                             );
-                            // eslint-disable-next-line unicorn/prefer-add-event-listener
                             audioReference.current.onended = () => {
                                 audioReference &&
                                     audioReference.current &&
@@ -425,8 +424,8 @@ function RenderModal({
                             {type === "new"
                                 ? "Generated files"
                                 : type === "mod"
-                                ? "Files changed after render"
-                                : "Unmodified files"}
+                                  ? "Files changed after render"
+                                  : "Unmodified files"}
                         </h1>
                         <List css={rootStyle}>
                             {Object.keys(data).map((filename) => {
@@ -537,9 +536,8 @@ function RenderModal({
                         onClick={async () => {
                             const bundle = new JSZip();
                             for (const filename of selectedFiles) {
-                                const arrayBuffer = await csound.fs.readFile(
-                                    filename
-                                );
+                                const arrayBuffer =
+                                    await csound.fs.readFile(filename);
                                 bundle.file(filename, arrayBuffer);
                             }
 

diff --git a/src/components/editor/plugins/show-hint.js b/src/components/editor/plugins/show-hint.js
@@ -80,11 +80,10 @@ function Completion(cm, options) {
         this.cm.getLine(this.startPos.line).length -
         this.cm.getSelection().length;
 
-    const self = this;
     cm.on(
         "cursorActivity",
-        (this.activityFunc = function () {
-            self.cursorActivity();
+        (this.activityFunc = () => {
+            this.cursorActivity();
         })
     );
 }
@@ -152,9 +151,8 @@ Completion.prototype = {
         ) {
             this.close();
         } else {
-            const self = this;
-            this.debounce = requestAnimationFrame(function () {
-                self.update();
+            this.debounce = requestAnimationFrame(() => {
+                this.update();
             });
             if (this.widget) {
                 this.widget.disable();
@@ -166,11 +164,11 @@ Completion.prototype = {
         if (!this.tick) {
             return;
         }
-        const self = this;
         const myTick = ++this.tick;
-        fetchHints(this.options.hint, this.cm, this.options, function (data) {
-            if (self.tick === myTick) {
-                self.finishUpdate(data, first);
+
+        fetchHints(this.options.hint, this.cm, this.options, (data) => {
+            if (this.tick === myTick) {
+                this.finishUpdate(data, first);
             }
         });
     },
@@ -321,8 +319,7 @@ function Widget(completion, data) {
     this.completion = completion;
     this.data = data;
     this.picked = false;
-    const widget = this,
-        cm = completion.cm;
+    const cm = completion.cm;
     const ownerDocument = cm.getInputField().ownerDocument;
     const parentWindow =
         ownerDocument.defaultView || ownerDocument.parentWindow;
@@ -440,21 +437,21 @@ function Widget(completion, data) {
 
     cm.addKeyMap(
         (this.keyMap = buildKeyMap(completion, {
-            moveFocus: function (n, avoidWrap) {
-                widget.changeActive(widget.selectedHint + n, avoidWrap);
+            moveFocus: (n, avoidWrap) => {
+                this.changeActive(this.selectedHint + n, avoidWrap);
             },
-            setFocus: function (n) {
-                widget.changeActive(n);
+            setFocus: (n) => {
+                this.changeActive(n);
             },
-            menuSize: function () {
-                return widget.screenAmount();
+            menuSize: () => {
+                return this.screenAmount();
             },
             length: completions.length,
             close: function () {
                 completion.close();
             },
-            pick: function () {
-                widget.pick();
+            pick: () => {
+                this.pick();
             },
             data: data
         }))
@@ -502,20 +499,20 @@ function Widget(completion, data) {
         })
     );
 
-    CodeMirror.on(hints, "dblclick", function (event) {
+    CodeMirror.on(hints, "dblclick", (event) => {
         const t = getHintElement(hints, event.target || event.srcElement);
         if (t && t.hintId) {
-            widget.changeActive(t.hintId);
-            widget.pick();
+            this.changeActive(t.hintId);
+            this.pick();
         }
     });
 
-    CodeMirror.on(hints, "click", function (event) {
+    CodeMirror.on(hints, "click", (event) => {
         const t = getHintElement(hints, event.target || event.srcElement);
         if (t && t.hintId) {
-            widget.changeActive(t.hintId);
+            this.changeActive(t.hintId);
             if (completion.options.completeOnSingleClick) {
-                widget.pick();
+                this.pick();
             }
         }
     });
@@ -555,10 +552,9 @@ Widget.prototype = {
 
     disable: function () {
         this.completion.cm.removeKeyMap(this.keyMap);
-        const widget = this;
         this.keyMap = {
-            Enter: function () {
-                widget.picked = true;
+            Enter: () => {
+                this.picked = true;
             }
         };
         this.completion.cm.addKeyMap(this.keyMap);

diff --git a/src/components/file-tree/context.tsx b/src/components/file-tree/context.tsx
@@ -32,7 +32,6 @@ const initialState: DnDState = { docIdx: {} };
 export const DnDStateContext = createContext(initialState);
 
 export const DnDDispatchContext = createContext(
-    // eslint-disable-next-line @typescript-eslint/no-empty-function,@typescript-eslint/no-unused-vars
     (dispatch: Record<string, any>): void => {}
 );
 
@@ -129,17 +128,17 @@ const reducer = (state: DnDState, action: Record<string, any>): DnDState => {
             );
 
             const newState = reduceIndexed(
-                (accumulator, item, newIndex) =>
+                (accumulator, item: any, newIndex) =>
                     assocPath(
                         ["docIdx", item.uid, "index"],
                         newIndex,
                         accumulator
                     ),
-                state,
+                state as DnDState,
                 reorderedFiles
             );
 
-            return newState;
+            return newState as DnDState;
         }
         case "setDocIdx": {
             return assoc("docIdx", action.docIdx, state);

diff --git a/src/components/hot-keys/hot-keys.tsx b/src/components/hot-keys/hot-keys.tsx
@@ -41,7 +41,6 @@ const HotKeys = ({
                 {},
                 [...keyboardCallbacks.keys()]
             ),
-        /* eslint-disable-next-line react-hooks/exhaustive-deps */
         [updateCounter]
     );
     return (

diff --git a/src/components/main/main.tsx b/src/components/main/main.tsx
@@ -55,7 +55,6 @@ const Main = (): React.ReactElement => {
                 (window as any).ps_body &&
                 (window as any).ps_body.destroy();
         };
-        // eslint-disable-next-line react-hooks/exhaustive-deps
     }, []);
 
     return (

diff --git a/src/components/profile/actions.tsx b/src/components/profile/actions.tsx
@@ -86,7 +86,6 @@ const handleProjectTags = async (projectUid, loggedInUserUid, currentTags) => {
         query(tags, where(projectUid, "==", loggedInUserUid))
     );
 
-    /* eslint-disable-next-line unicorn/prefer-object-from-entries */
     const currentProjTags = currentProjTagsReference.docs.reduce(
         (accumulator, document_) =>
             assoc(document_.id, document_.data(), accumulator),

diff --git a/src/components/project-editor/actions.tsx b/src/components/project-editor/actions.tsx
@@ -1,7 +1,6 @@
 import { openSimpleModal } from "@comp/modal/actions";
 import { IDocument } from "@comp/projects/types";
 import { ITarget } from "@comp/target-controls/types";
-import { find, propEq } from "ramda";
 import { sortByStoredTabOrder } from "./utils";
 import {
     MANUAL_LOOKUP_STRING,
@@ -79,19 +78,16 @@ export const tabDockInit = (
             });
         });
     } else if (
-        /* eslint-disable-next-line unicorn/no-useless-length-check */
         allDocuments.length > 0 &&
-        /* eslint-disable-next-line unicorn/no-useless-length-check */
         allDocuments.some((d) => d.filename === "project.csd")
     ) {
-        const projectCsd = find(
-            propEq("filename", "project.csd"),
-            allDocuments
+        const projectCsd = allDocuments.find(
+            (d) => d.filename === "project.csd"
         );
+
         projectCsd &&
-            !find(
-                propEq("uid", projectCsd.documentUid),
-                initialOpenDocuments
+            !initialOpenDocuments.find(
+                (d) => d.uid === projectCsd.documentUid
             ) &&
             initialOpenDocuments.push({
                 uid: projectCsd.documentUid

diff --git a/src/components/project-editor/project-editor.tsx b/src/components/project-editor/project-editor.tsx
@@ -60,6 +60,8 @@ type IEditorForDocumentProperties = {
     isOwner: boolean;
 };
 
+type AnyTab = IDocument | IOpenDocument | NonCloudFile;
+
 const MySplit = ({
     primary,
     split,
@@ -70,7 +72,6 @@ const MySplit = ({
     onDragFinished,
     children
 }) => {
-    /* eslint-disable-next-line  unicorn/prefer-native-coercion-functions */
     const filteredChildren = children.filter(Boolean);
     return filteredChildren.length === 1 ? (
         filteredChildren[0]
@@ -182,7 +183,6 @@ const ProjectEditor = ({
         activeProject
     );
     const isOwner: boolean = useSelector(selectIsOwner(projectUid));
-    // eslint-disable-next-line unicorn/no-useless-undefined
     const csound: CsoundObj | undefined = undefined;
 
     useEffect(() => {
@@ -236,11 +236,8 @@ const ProjectEditor = ({
         pathOr(-1, ["ProjectEditorReducer", "tabDock", "tabIndex"])
     );
 
-    const openDocuments: (IDocument | IOpenDocument)[] = reduce(
-        (
-            accumulator: (IDocument | IOpenDocument)[],
-            tabDocument: IOpenDocument
-        ) => {
+    const openDocuments: AnyTab[] = tabDockDocuments.reduce(
+        (accumulator: AnyTab[], tabDocument: IOpenDocument) => {
             const maybeDocument = pathOr(
                 {} as IDocument,
                 ["documents", propOr("", "uid", tabDocument)],
@@ -252,11 +249,10 @@ const ProjectEditor = ({
             return isNonCloudFile
                 ? append(tabDocument, accumulator)
                 : maybeDocument && Object.keys(maybeDocument).length > 0
-                ? append(maybeDocument, accumulator)
-                : accumulator;
+                  ? append(maybeDocument, accumulator)
+                  : accumulator;
         },
-        [] as (IDocument | NonCloudFile)[],
-        tabDockDocuments
+        [] as AnyTab[]
     );
 
     const closeTab = (documentUid, isModified) => {
@@ -376,7 +372,9 @@ const ProjectEditor = ({
         <MobileTabs
             activeProject={activeProject}
             projectUid={projectUid}
-            currentDocument={openDocuments[tabIndex]}
+            currentDocument={
+                openDocuments[tabIndex] as IDocument | IOpenDocument | undefined
+            }
         />
     ) : (
         <>