Skip to content

Commit

Permalink
feat(functions): explicit appName in app initialiser
Browse files Browse the repository at this point in the history
  • Loading branch information
hlolli committed Dec 10, 2024
1 parent 8e57240 commit 46a783a
Show file tree
Hide file tree
Showing 8 changed files with 22 additions and 15 deletions.
5 changes: 3 additions & 2 deletions functions/src/add_project_file_on_storage_upload.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ import { initializeApp } from "firebase-admin/app";
import { onObjectFinalized } from "firebase-functions/v2/storage";
import { makeLogger } from "./logger.js";

initializeApp(); // ensure this is done somewhere in your setup
const log = makeLogger("addProjectFileOnStorageUpload");
const functionName = "addProjectFileOnStorageUpload";
initializeApp(undefined, functionName);
const log = makeLogger(functionName);
const newTimestamp = admin.firestore.FieldValue.serverTimestamp();

export const addProjectFileOnStorageUploadCallback = onObjectFinalized(
Expand Down
6 changes: 3 additions & 3 deletions functions/src/delete_user.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import { initializeApp } from "firebase-admin/app";
import functions from "firebase-functions/v1";
import { makeLogger } from "./logger.js";

const log = makeLogger("deleteUser");

initializeApp();
const functionName = "deleteUser";
initializeApp(undefined, functionName);
const log = makeLogger(functionName);

const deleteUserDocument = async (
user: admin.auth.UserRecord
Expand Down
3 changes: 2 additions & 1 deletion functions/src/followers_counter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import { initializeApp } from "firebase-admin/app";
import { onDocumentWritten } from "firebase-functions/v2/firestore";
import { makeLogger } from "./logger.js";

initializeApp();
const functionName = "followersCounter";
initializeApp(undefined, functionName);
const log = makeLogger("followersCounter");

export const followersCounter = onDocumentWritten(
Expand Down
5 changes: 3 additions & 2 deletions functions/src/following_counter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ import { initializeApp } from "firebase-admin/app";
import { onDocumentWritten } from "firebase-functions/v2/firestore";
import { makeLogger } from "./logger.js";

initializeApp();
const log = makeLogger("followersCounter");
const functionName = "followersCounter";
initializeApp(undefined, functionName);
const log = makeLogger(functionName);

export const followingCounter = onDocumentWritten(
"following/{userUid}",
Expand Down
3 changes: 2 additions & 1 deletion functions/src/host.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ import fs from "node:fs";
import path from "node:path";
import * as R from "ramda";

initializeApp();
const functionName = "host";
initializeApp(undefined, functionName);

function printTree(dirPath: string, indent = "") {
const files = fs.readdirSync(dirPath);
Expand Down
5 changes: 3 additions & 2 deletions functions/src/new_user.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ import { initializeApp } from "firebase-admin/app";
import functions from "firebase-functions/v1";
import { makeLogger } from "./logger.js";

initializeApp();
const log = makeLogger("newUser");
const functionName = "newUser";
initializeApp(undefined, functionName);
const log = makeLogger(functionName);

async function createProfileDocument(
user: admin.auth.UserRecord
Expand Down
5 changes: 3 additions & 2 deletions functions/src/project_file_storage_delete.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ import { onDocumentDeleted } from "firebase-functions/v2/firestore";
import { config } from "firebase-functions/v1";
import { makeLogger } from "./logger.js";

initializeApp();
const log = makeLogger("projectFileStorageDelete");
const functionName = "projectFileStorageDelete";
initializeApp(undefined, functionName);
const log = makeLogger(functionName);

async function projectFileStorageDelete(binaryUrl: string): Promise<void> {
log(
Expand Down
5 changes: 3 additions & 2 deletions functions/src/projects_counter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ import { FieldValue } from "firebase-admin/firestore";
import { onDocumentWritten } from "firebase-functions/v2/firestore";
import { makeLogger } from "./logger.js";

initializeApp();
const log = makeLogger("projectsCounter");
const functionName = "projectsCounter";
initializeApp(undefined, functionName);
const log = makeLogger(functionName);

export const projectsCounter = onDocumentWritten(
"projects/{projectUid}",
Expand Down

0 comments on commit 46a783a

Please sign in to comment.