Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media query styles applied only to the first element in function #1442

Merged
merged 12 commits into from
Jan 19, 2021
Merged

Media query styles applied only to the first element in function #1442

merged 12 commits into from
Jan 19, 2021

Conversation

kof
Copy link
Member

@kof kof commented Jan 18, 2021

Corresponding issue (if exists):

#1320
#1343

@kof kof requested a review from HenriBeck as a code owner January 18, 2021 19:33
@kof
Copy link
Member Author

kof commented Jan 18, 2021 •
edited
Loading

I have merged the test without the lib changes and it passes, which means it doesn't verify any fixes made by code changes.
Which means we are stuck at the testing phase. We need proper tests that verify what those changes fix.

@kof kof mentioned this pull request Jan 18, 2021
Open
3 tasks
@kof kof changed the title Pranshuchittora pc/fix/react jss/dynamic sheet Media query styles applied only to the first element in function Jan 19, 2021
@kof kof merged commit 94c8f6c into master Jan 19, 2021
@kof kof deleted the pranshuchittora-pc/fix/react-jss/dynamicSheet branch January 19, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenriBeck HenriBeck Awaiting requested review from HenriBeck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kof @pranshuchittora @mattbsurveymonkey @vepasto