Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract mailadress to .env file #460

Merged
merged 13 commits into from
Nov 21, 2024
Merged

Extract mailadress to .env file #460

merged 13 commits into from
Nov 21, 2024

Conversation

lodewiges
Copy link
Contributor

@lodewiges lodewiges commented Nov 12, 2024

Fixes #136
This PR extracts all the emailadresses to the .env file
It also changes to the default mail adres for archive notifications
and the email adres in the templates of unavailable mailadress template to be inline with bounced emails template.

before merging the .env files should be changed on the server

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (fbf1070) to head (84b5ede).
Report is 1 commits behind head on staging.

Additional details and impacted files
@@           Coverage Diff            @@
##           staging     #460   +/-   ##
========================================
  Coverage    99.92%   99.92%           
========================================
  Files          207      207           
  Lines         2733     2733           
========================================
  Hits          2731     2731           
  Misses           2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@DrumsnChocolate DrumsnChocolate changed the title abstracting mailadress to .env file Extract mailadress to .env file Nov 13, 2024
app/mailers/user_cleanup_mailer.rb Show resolved Hide resolved
config/application.rb Show resolved Hide resolved
spec/jobs/user_cleanup_job_spec.rb Show resolved Hide resolved
Copy link
Contributor

@DrumsnChocolate DrumsnChocolate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only read through the code, I have not tested this locally

@lodewiges lodewiges added this pull request to the merge queue Nov 21, 2024
Merged via the queue into staging with commit 7eafcf6 Nov 21, 2024
5 checks passed
@lodewiges lodewiges deleted the fix/mailadresAbstract branch November 21, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hardcoded mailadresses
2 participants