refactor(components): co-locate templates with classes #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocation' into refactor/component-templates-colocation # Conflicts: # app/components/advertisement-tool.hbs # app/components/basic-modal.hbs # app/components/boolean-tag.hbs # app/components/bread-crumbs.hbs # app/components/cards/activity-card.hbs # app/components/cards/article-card.hbs # app/components/cards/frontpage-activity-card-small.hbs # app/components/cards/frontpage-article-card.hbs # app/components/cards/membership-card.hbs # app/components/cards/photo-album-card.hbs # app/components/cards/privacy-preference.hbs # app/components/filter-bar.hbs # app/components/flash-notice.hbs # app/components/footer-nav.hbs # app/components/form-control-feedback.hbs # app/components/form/closed-question.hbs # app/components/form/consumption-list.hbs # app/components/form/form-form.hbs # app/components/form/open-question.hbs # app/components/form/response/closed-question.hbs # app/components/form/response/form-closed-alert.hbs # app/components/form/response/multiple-choice-question.hbs # app/components/form/response/open-question.hbs # app/components/form/response/response-card.hbs # app/components/form/response/response-completed-alert.hbs # app/components/form/response/response-form.hbs # app/components/form/responses-table-card.hbs # app/components/form/responses-table-row.hbs # app/components/form/responses-table-totals.hbs # app/components/form/responses-table.hbs # app/components/form/status-dot.hbs # app/components/form/status-icon.hbs # app/components/form/status-tag.hbs # app/components/forum/forum-post-new.hbs # app/components/forum/forum-post.hbs # app/components/forum/status-icon.hbs # app/components/header-nav.hbs # app/components/index/authenticated.hbs # app/components/index/public.hbs # app/components/index/public/about-alpha.hbs # app/components/index/public/about-flux.hbs # app/components/index/public/action-buttons.hbs # app/components/index/public/activities.hbs # app/components/index/public/articles.hbs # app/components/index/public/member-stories.hbs # app/components/index/public/photos.hbs # app/components/index/public/static-pages.hbs # app/components/index/public/youtube-videos.hbs # app/components/index/special-promo.hbs # app/components/index/sponsorkliks-alert.hbs # app/components/input/date-input.hbs # app/components/input/datetime-input.hbs # app/components/input/select-input.hbs # app/components/input/time-input.hbs # app/components/md-editor.hbs # app/components/md-editor/md-editor-toolbar.hbs # app/components/menu-sidebar-item.hbs # app/components/menu-sidebar-link.hbs # app/components/menu-sidebar.hbs # app/components/model-form/checkbox-group.hbs # app/components/model-form/checkbox-input.hbs # app/components/model-form/date-input.hbs # app/components/model-form/datetime-input.hbs # app/components/model-form/file-input.hbs # app/components/model-form/form-actions.hbs # app/components/model-form/md-input.hbs # app/components/model-form/radio-group.hbs # app/components/model-form/select-input.hbs # app/components/model-form/text-input.hbs # app/components/model-form/textarea-input.hbs # app/components/page-action.hbs # app/components/page-actions-buttons.hbs # app/components/page-actions.hbs # app/components/page-numbers.hbs # app/components/permissions/permissions-table-item.hbs # app/components/permissions/permissions-table.hbs # app/components/poll/closed-question.hbs # app/components/poll/poll-form.hbs # app/components/poll/status-tag.hbs # app/components/privacy-modal.hbs # app/components/quick-post-notification-button.hbs # app/components/quick-post.hbs # app/components/social-media-buttons.hbs # app/components/tabbed-view.hbs # app/components/tools/board-room-presence.hbs # app/components/tools/closing-activities.hbs # app/components/tools/daily-verse.hbs # app/components/tools/forum-posts.hbs # app/components/tools/recent-photos.hbs # app/components/tools/recent-polls.hbs # app/components/tools/upcoming-activities.hbs # app/components/tools/upcoming-birthdays.hbs # app/components/user-comment.hbs # app/components/users/otp-settings.hbs # app/components/users/password-settings.hbs # app/components/users/privacy-settings.hbs # app/components/youtube-video.hbs
wilco375
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Co-locates the components' templates with their classes.
Why: https://emberjs.github.io/rfcs/0481-component-templates-co-location.html
This PR is also an initial step to make refactoring to Glimmer Components (task in this issue) easier.
Other information
I (only) ran this codemod to move the templates: https://github.com/ember-codemods/ember-component-template-colocation-migrator