feat: ember-cli-update #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
…blueprint refactor(package): follow ember-new-output as close as possible refactor(server): make proxies and server follow blueprints chore(deps): specify moment-duration-format patch version fix(ci): configure ember-cli-update correctly fix(renovate): only include package and new value in PR fix(renovate): change new value column to change fix(renovate): don't group ember-cli updates feat: save ember-cli update state fix(ci): install after ember-cli-update with immutable false fix(ci): use correct flag for mutable yarn install fix(ci): fetch previous ref too for ember-cli-update fix(ci): checkout code on head_ref fix(ci): don't commit changes to .github fix(ci): remove file directly instead of git rm fix(ci): remove ember-cli-update step refactor(renovate): group ember-cli deps again fix(renovate): remove rangeStrategy for ember-cli package fix(renovate): swap matchPackageNames feat(ci): make patch ember-cli updates not draft PRs fix(renovate): use correct dockerfile manager name fix(renovate): change commitMessageTopic to exclude docker tags feat(ci): readd ember-cli-update action fix(ci): try fixing with syntax refactor(ci): move ember-cli-update to own job fix(ci): change column definition to max action regex feat(ci): get token from app fix(ci): add if to build step fix(ci): change actor name fix(ci): add status check to if fix(ci): check if renovate is actor other way fix(ci): move comment to hopefully fix autofix_command fix(ci): run lint and test when build succeeds chore(deps): downgrade danlynn/ember-cli feat: track ember-data with ember-cli-update feat: install ember-cli-update fix: remove ember-cli from npm deps packageRules fix(renovate): remove separateMinorPatch from ember-cli packageRules fix(package): change ember-cli constraint revert: changes from the prettier PR feat: add missing files
…taging � Conflicts: � .eslintrc.js � .github/renovate.json � package.json � server/index.js � yarn.lock
1 task
| 'use strict'; | ||
|
|
||
| const EmberApp = require('ember-cli/lib/broccoli/ember-app'); | ||
|
|
||
| module.exports = function (defaults) { | ||
| const app = new EmberApp(defaults, { | ||
| let app = new EmberApp(defaults, { |
There was a problem hiding this comment.
This was automatically changed by the blueprint updates.
I see there's not a general consensus in the Ember community of which one to use (some big addon maintainers apparently prefer "liberal let" instead of "constantly const").
The default ESLint configuration that comes with the Ember app blueprint does not include any rule that enforces one or the other.
What should we do here?
- We could allow both (Ember default app blueprint does that).
- We could configure ESLint's
prefer-constand keep reverting these automatic conversions byember-cli-update. - We could install some ESLint plugin to enforce let.
There was a problem hiding this comment.
eh, I think option 1 is best then, it doesn't really matter that much if it's this much of a discussion in the Ember community. I am just surprised by it, because I am used to getting bashed for not using cost instead of let whenever possible
There was a problem hiding this comment.
Ah yes I was one of those people 😂 apologies
wilco375
approved these changes
Apr 6, 2022
DrumsnChocolate
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tracks the
ember-cliapp blueprint to its current version inconfig/ember-cli-update.jsonso we can useember-cli-updateto update it. I then updatedember-clito the last v3 version. Some order of lines in files was changed so that in the future whenember-cli-updateis used, the amount of merge conflicts caused by the process should be minimised.It looked like you can track any blueprint with
ember-cli-update(like model, component, controller, route, ...), but it doesn't seem to actually support that (yet). For now, using this to update the base blueprint works pretty well.Because of #501 and
danlynn/ember-cliDocker image now using Node 16, I used yarn resolutions to forceworkerpool@^2.3.0to^2.3.4. Whenember-crumblyis replaced, this can be removed.Also
@embroider/macrosis forced to^1.0.0because of another error.Other information
https://github.com/ember-cli/ember-cli-update
App blueprint: https://github.com/ember-cli/ember-new-output