Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency stylelint-config-standard to v29 #628

Merged
merged 3 commits into from
Dec 30, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 15, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
stylelint-config-standard ^28.0.0 -> ^29.0.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Oct 15, 2022
@renovate renovate bot force-pushed the renovate/stylelint-config-standard-29.x branch 7 times, most recently from 878f974 to b1f889d Compare October 29, 2022 14:30
@renovate renovate bot force-pushed the renovate/stylelint-config-standard-29.x branch 3 times, most recently from 9dc396c to 16c76ef Compare November 2, 2022 21:48
@renovate renovate bot force-pushed the renovate/stylelint-config-standard-29.x branch 3 times, most recently from 775ebab to 70791e0 Compare November 20, 2022 21:52
@renovate renovate bot force-pushed the renovate/stylelint-config-standard-29.x branch from 70791e0 to da3dde0 Compare November 26, 2022 14:30
@wilco375 wilco375 enabled auto-merge (squash) November 26, 2022 14:47
@guidojw
Copy link
Member

guidojw commented Nov 26, 2022

Why not conform with the new setting instead of ignoring it?

@wilco375 wilco375 disabled auto-merge November 26, 2022 14:50
@wilco375
Copy link
Contributor

wilco375 commented Nov 26, 2022

Why not conform with the new setting instead of ignoring it?

It seems very unintuitive for me to be using url for local files. But if others feel that using url would be better it can also be updated to that.

By the way, the sass documentation also uses string almost everywhere.

@guidojw
Copy link
Member

guidojw commented Nov 26, 2022

I figured we're using the base ESLint/stylelint/templatelint configs for a reason and shouldn't want to deviate much from them (the goal in #429 for example is to get rid of most rule ignores).

stylelint-config-standard rationale: stylelint/stylelint-config-standard#265

@renovate
Copy link
Contributor Author

renovate bot commented Nov 28, 2022

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@guidojw
Copy link
Member

guidojw commented Dec 30, 2022

Experimented with url() but couldn't get it to work, so approving the ignore

@guidojw guidojw enabled auto-merge (squash) December 30, 2022 22:17
@guidojw guidojw merged commit e23e65c into staging Dec 30, 2022
@guidojw guidojw deleted the renovate/stylelint-config-standard-29.x branch December 30, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants