Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI run running on oldest supported versions of core dependencies #2619

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,12 @@ jobs:
strategy:
matrix:
include:
- name: Linux (3.10, mamba)
- name: Linux (3.10, mamba, oldest-deps)
os: ubuntu-latest
python-version: "3.10"
install-method: mamba
extras: tests,all
extra-args: ["oldest-deps"]

- name: Linux (3.10, pip)
os: ubuntu-latest
Expand Down Expand Up @@ -143,7 +144,11 @@ jobs:
pip install -e ".[${EXTRAS}]"
pip install ./test_plugin
pip freeze
pip list

- if: contains(matrix.extra-args, 'oldest-deps') && contains(github.event.pull_request.labels.*.name, 'documentation-only') == false
run: |
micromamba install -n cta-dev -y numpy=1.24 numba=0.57 scipy=1.10 astropy=6.1 matplotlib=3.6
micromamba list -n cta-dev

- name: ctapipe-info
if: contains(github.event.pull_request.labels.*.name, 'documentation-only') == false
Expand Down
4 changes: 2 additions & 2 deletions environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ channels:
dependencies:
- python=3.11
- pip
- astropy>=5.3,<8
- astropy>=6.1,<8
- black
- bokeh=3
- nbsphinx
Expand All @@ -19,7 +19,7 @@ dependencies:
- jupyter
- matplotlib
- numba>=0.56
- numpy>=1.22
- numpy>=1.24
- numpydoc
- pandas
- pypandoc
Expand Down
8 changes: 4 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,17 @@ dynamic = ["version"]
requires-python = ">=3.10"

dependencies = [
"astropy >=5.3,<8.0.0a0",
"astropy >=6.1,<8.0.0a0",
"docutils",
"joblib",
"numba >=0.56",
"numpy >=1.23,<3.0.0a0",
"numba >=0.57",
"numpy >=1.24,<3.0.0a0",
"packaging",
"psutil",
"pyyaml >=5.1",
"requests",
"scikit-learn !=1.4.0", # 1.4.0 breaks with astropy tables, before and after works
"scipy ~=1.2",
"scipy ~=1.10",
"tables ~=3.4",
"tqdm >=4.32",
"traitlets ~=5.6",
Expand Down
Loading