Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Windows fixes #814

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Various Windows fixes #814

merged 1 commit into from
Nov 20, 2023

Conversation

scholarsmate
Copy link
Member

@scholarsmate scholarsmate commented Nov 16, 2023

Fixes Windows code so that the tests build and run successfully. Also fixes many of the lints and deprecations flagged in Visual Studio 2022.

@scholarsmate scholarsmate self-assigned this Nov 16, 2023
@scholarsmate scholarsmate force-pushed the windows_fixes branch 4 times, most recently from 819faeb to c244c4f Compare November 16, 2023 05:14
@scholarsmate scholarsmate changed the title interim commit Various Windows fixes Nov 16, 2023
@scholarsmate scholarsmate added this to the v1.0.0 milestone Nov 16, 2023
@scholarsmate scholarsmate marked this pull request as ready for review November 16, 2023 05:19
@scholarsmate scholarsmate force-pushed the windows_fixes branch 7 times, most recently from 9b37f1c to ce2c4be Compare November 17, 2023 02:52
Copy link
Collaborator

@shanedell shanedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@scholarsmate scholarsmate force-pushed the windows_fixes branch 3 times, most recently from 271792c to 84af5ac Compare November 20, 2023 22:59
@scholarsmate scholarsmate added this pull request to the merge queue Nov 20, 2023
Merged via the queue into main with commit 5a58de9 Nov 20, 2023
13 checks passed
@scholarsmate scholarsmate deleted the windows_fixes branch November 20, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants