Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confluence v2 get children #208

Merged

Conversation

squatched
Copy link
Contributor

@squatched squatched commented Jun 3, 2023

Fixes #207 (GET Get child pages).

Sorry if this doesn't fit your organizational scheme or naming pattern. I'm still trying to build a reasonable mental model of how your package is laid out in comparison to the reference docs...

@@ -37,7 +37,7 @@ to .

> If you want to ask a question, we assume that you have read the available [Documentation](https://docs.go-atlassian.io/).

Before you ask a question, it is best to search for existing [Issues](https://github.com/ctreminiom/go-atlassianissues) that might help you. In case you have found a suitable issue and still need clarification, you can write your question in this issue. It is also advisable to search the internet for answers first.
Before you ask a question, it is best to search for existing [Issues](https://github.com/ctreminiom/go-atlassian/issues) that might help you. In case you have found a suitable issue and still need clarification, you can write your question in this issue. It is also advisable to search the internet for answers first.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly related of course but was reading through these guidelines and noticed this.

@squatched squatched changed the title Add confluence v2 get children [ctreminiom/go-atlassian#207] Add confluence v2 get children Jun 6, 2023
@squatched squatched changed the title [ctreminiom/go-atlassian#207] Add confluence v2 get children Add confluence v2 get children Jun 6, 2023
@ctreminiom ctreminiom added enhancement New feature or request Confluence labels Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #208 (c4ead4e) into main (97c7c52) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   89.25%   89.27%   +0.01%     
==========================================
  Files         148      148              
  Lines       11626    11644      +18     
==========================================
+ Hits        10377    10395      +18     
  Misses        632      632              
  Partials      617      617              
Files Changed Coverage Δ
confluence/internal/page_impl.go 92.20% <100.00%> (+1.03%) ⬆️

@squatched
Copy link
Contributor Author

Documentation PR: ctreminiom/go-atlassian-docs#1

@ctreminiom ctreminiom added this to the Confluence Cloud V2 Module milestone Jun 18, 2023
@ctreminiom
Copy link
Owner

closing pr due inactivity

@ctreminiom ctreminiom closed this Aug 14, 2023
@squatched
Copy link
Contributor Author

I'm sorry but what activity was needed? I don't see any feedback here and I've been using a custom build of go-atlassian using this PR for weeks now without issue. Is there something that needs to change?

@ctreminiom ctreminiom reopened this Aug 17, 2023
@squatched
Copy link
Contributor Author

What needs to be done to get this merged? Anything I can help with?

Repository owner deleted a comment from tobarbaro Feb 10, 2024
@ctreminiom ctreminiom merged commit 1c885a2 into ctreminiom:main Mar 8, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confluence enhancement New feature or request
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

Add Confluence V2 Get Children
2 participants