Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #240: Adjust SpaceSchemeV2 id & homepageID Types #241

Merged

Conversation

squatched
Copy link
Contributor

Fixes #240 by addressing the following two discrepancies between Confluence Space V2 API's Get Method return values and SpaceSchemaV2's member types':

  • Confluence Space V2 API Returns HomepageID As String
  • Confluence Space V2 API Returns ID As String

@squatched
Copy link
Contributor Author

Not sure if this is how you actually want to address this since this is somewhat of a breaking change for folks already using this particular API method...

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #241 (c7a7787) into main (97c7c52) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   89.25%   89.25%           
=======================================
  Files         148      148           
  Lines       11626    11626           
=======================================
  Hits        10377    10377           
  Misses        632      632           
  Partials      617      617           

@ctreminiom
Copy link
Owner

Hi @squatched, thanks for this PR...

I would think to release a new version of the library (v1.5.1) after merge this PR on a new major release (v.1.6.0) due it's breaking change :)

@ctreminiom
Copy link
Owner

@squatched thanks for the contribution!

@ctreminiom ctreminiom merged commit 7ad0339 into ctreminiom:main Sep 22, 2023
27 checks passed
@squatched squatched deleted the fix-confluence-v2-get-space-types branch April 16, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

Confluence V2 API Space Get Returns Strings For IDs
2 participants