Updated code style #308
Updated code style #308
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) | ||
|
|
||
| func New(httpClient common.HttpClient, site string) (*Client, error) { | ||
| func New(httpClient common.HTTPClient, site string) (*Client, error) { |
Check warning
Code scanning / Revive (reported by Codacy)
exported function New should have comment or be unexported Warning
| @@ -75,7 +76,7 @@ | |||
| Analytics *internal.AnalyticsService | |||
| } | |||
|
|
|||
| func (c *Client) NewRequest(ctx context.Context, method, urlStr, type_ string, body interface{}) (*http.Request, error) { | |||
| func (c *Client) NewRequest(ctx context.Context, method, urlStr, contentType string, body interface{}) (*http.Request, error) { | |||
Check warning
Code scanning / Revive (reported by Codacy)
exported method Client.NewRequest should have comment or be unexported Warning
| ) | ||
|
|
||
| func New(httpClient common.HttpClient, site string) (*Client, error) { | ||
| func New(httpClient common.HTTPClient, site string) (*Client, error) { |
Check warning
Code scanning / Revive (reported by Codacy)
exported function New should have comment or be unexported Warning
| @@ -57,7 +58,7 @@ | |||
| CustomContent *internal.CustomContentService | |||
| } | |||
|
|
|||
| func (c *Client) NewRequest(ctx context.Context, method, urlStr, type_ string, body interface{}) (*http.Request, error) { | |||
| func (c *Client) NewRequest(ctx context.Context, method, urlStr, contentType string, body interface{}) (*http.Request, error) { | |||
Check warning
Code scanning / Revive (reported by Codacy)
exported method Client.NewRequest should have comment or be unexported Warning
| ) | ||
|
|
||
| func New(httpClient common.HttpClient, site string) (*Client, error) { | ||
| func New(httpClient common.HTTPClient, site string) (*Client, error) { |
Check warning
Code scanning / Revive (reported by Codacy)
exported function New should have comment or be unexported Warning
|
@ctreminiom i would recomemnd squashing my commits, always. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
==========================================
+ Coverage 88.88% 88.90% +0.01%
==========================================
Files 158 158
Lines 12376 12308 -68
==========================================
- Hits 11000 10942 -58
+ Misses 724 720 -4
+ Partials 652 646 -6 ☔ View full report in Codecov by Sentry. |
Changed Id -> ID
Aligned function comments with function arguments
Added linter rule to prevent unwanted future style changes to github workflows.