[WIP] try to combine llvm-cov and insta test run

cube-js · Jan 23, 2025 · 52ec480 · 52ec480
1 parent 1848739
commit 52ec480
Showing 1 changed file with 4 additions and 11 deletions.
diff --git a/.github/workflows/rust-cubesql.yml b/.github/workflows/rust-cubesql.yml
@@ -104,18 +104,11 @@ jobs:
           CUBESQL_REWRITE_TIMEOUT: 60
         run: |
           cd rust/cubesql
-          cargo llvm-cov --all-features --workspace --lcov --output-path lcov.info
-      - name: Check unreferenced insta snapshots in tests (Rewrite Engine)
-        env:
-          CUBESQL_TESTING_CUBE_TOKEN: ${{ secrets.CUBESQL_TESTING_CUBE_TOKEN }}
-          CUBESQL_TESTING_CUBE_URL: ${{ secrets.CUBESQL_TESTING_CUBE_URL }}
-          CUBESQL_SQL_PUSH_DOWN: true
-          CUBESQL_TOP_DOWN_EXTRACTOR: ${{ matrix.top-down-extractor }}
-          CUBESQL_REWRITE_CACHE: true
-          CUBESQL_REWRITE_TIMEOUT: 60
-        run: |
-          cd rust/cubesql
+          # See https://github.com/taiki-e/cargo-llvm-cov/blob/main/README.md#get-coverage-of-external-tests
+          # shellcheck source=/dev/null
+          source <(cargo llvm-cov show-env --export-prefix)
           cargo insta test --all-features --workspace --unreferenced reject
+          cargo llvm-cov report --all-features --workspace --lcov --output-path lcov.info
       - name: Upload code coverage
         uses: codecov/codecov-action@v4
         with: