Fix clickhouseUseCollation tests to check for default value

cube-js · Feb 6, 2025 · ce3ec56 · ce3ec56
1 parent a2616fe
commit ce3ec56
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/cubejs-backend-shared/test/db_env_multi.test.ts b/packages/cubejs-backend-shared/test/db_env_multi.test.ts
@@ -1561,8 +1561,8 @@ describe('Multiple datasources', () => {
     delete process.env.CUBEJS_DB_CLICKHOUSE_SORT_COLLATION;
     delete process.env.CUBEJS_DS_POSTGRES_DB_CLICKHOUSE_SORT_COLLATION;
     delete process.env.CUBEJS_DS_WRONG_DB_CLICKHOUSE_SORT_COLLATION;
-    expect(getEnv('clickhouseSortCollation', { dataSource: 'default' })).toBeUndefined();
-    expect(getEnv('clickhouseSortCollation', { dataSource: 'postgres' })).toBeUndefined();
+    expect(getEnv('clickhouseSortCollation', { dataSource: 'default' })).toEqual('en');
+    expect(getEnv('clickhouseSortCollation', { dataSource: 'postgres' })).toEqual('en');
     expect(() => getEnv('clickhouseSortCollation', { dataSource: 'wrong' })).toThrow(
       'The wrong data source is missing in the declared CUBEJS_DATASOURCES.'
     );

diff --git a/packages/cubejs-backend-shared/test/db_env_single.test.ts b/packages/cubejs-backend-shared/test/db_env_single.test.ts
@@ -987,9 +987,9 @@ describe('Single datasources', () => {
     expect(getEnv('clickhouseSortCollation', { dataSource: 'wrong' })).toEqual('default2');
 
     delete process.env.CUBEJS_DB_CLICKHOUSE_SORT_COLLATION;
-    expect(getEnv('clickhouseSortCollation', { dataSource: 'default' })).toBeUndefined();
-    expect(getEnv('clickhouseSortCollation', { dataSource: 'postgres' })).toBeUndefined();
-    expect(getEnv('clickhouseSortCollation', { dataSource: 'wrong' })).toBeUndefined();
+    expect(getEnv('clickhouseSortCollation', { dataSource: 'default' })).toEqual('en');
+    expect(getEnv('clickhouseSortCollation', { dataSource: 'postgres' })).toEqual('en');
+    expect(getEnv('clickhouseSortCollation', { dataSource: 'wrong' })).toEqual('en');
   });
 
   test('getEnv("clickhouseUseCollation")', () => {