-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cubesql): Support SQL push down for more functions #7406
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7406 +/- ##
===========================================
+ Coverage 47.12% 71.21% +24.08%
===========================================
Files 155 327 +172
Lines 20832 54345 +33513
Branches 5362 5362
===========================================
+ Hits 9818 38701 +28883
- Misses 10166 14796 +4630
Partials 848 848
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e76fe3c
to
1448ba2
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
1448ba2
to
f93152f
Compare
f93152f
to
67dad87
Compare
Check List
Description of Changes Made
This PR adds SQL push down support for these functions:
NULLIF
ROUND
GREATEST
DLOG10
It also adds a
PI()
function, andGREATEST
function stub.Additionally,
IS NOT NULL
expression push down has been fixed.Finally,
LOG
template generator is extended for a few drivers.Related tests are included.