Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Support SQL push down for more functions #7406

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

MazterQyou
Copy link
Member

@MazterQyou MazterQyou commented Nov 11, 2023

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR adds SQL push down support for these functions:

  • NULLIF
  • ROUND
  • GREATEST
  • DLOG10

It also adds a PI() function, and GREATEST function stub.

Additionally, IS NOT NULL expression push down has been fixed.

Finally, LOG template generator is extended for a few drivers.

Related tests are included.

@MazterQyou MazterQyou requested review from a team as code owners November 11, 2023 12:42
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b25c199) 47.12% compared to head (67dad87) 71.21%.
Report is 2 commits behind head on master.

Files Patch % Lines
...bejs-schema-compiler/src/adapter/SnowflakeQuery.js 0.00% 2 Missing ⚠️
...ubejs-schema-compiler/src/adapter/BigqueryQuery.js 0.00% 1 Missing ⚠️
rust/cubesql/cubesql/src/compile/mod.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7406       +/-   ##
===========================================
+ Coverage   47.12%   71.21%   +24.08%     
===========================================
  Files         155      327      +172     
  Lines       20832    54345    +33513     
  Branches     5362     5362               
===========================================
+ Hits         9818    38701    +28883     
- Misses      10166    14796     +4630     
  Partials      848      848               
Flag Coverage Δ
cube-backend 47.04% <0.00%> (-0.09%) ⬇️
cubesql 86.23% <88.88%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MazterQyou MazterQyou force-pushed the cubesql/push-down-fns branch from e76fe3c to 1448ba2 Compare November 11, 2023 20:42
Copy link

vercel bot commented Nov 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-react-d3 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 10:09pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 10:09pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 10:09pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 10:09pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 10:09pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 10:09pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 10:09pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 10:09pm

@MazterQyou MazterQyou force-pushed the cubesql/push-down-fns branch from 1448ba2 to f93152f Compare November 11, 2023 20:57
@MazterQyou MazterQyou force-pushed the cubesql/push-down-fns branch from f93152f to 67dad87 Compare November 14, 2023 22:08
@paveltiunov paveltiunov merged commit b1606da into master Nov 14, 2023
57 checks passed
@paveltiunov paveltiunov deleted the cubesql/push-down-fns branch November 14, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants