Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(schema-compiler): Migrate dialects to TypeScript #7462

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

ovr
Copy link
Member

@ovr ovr commented Nov 27, 2023

Hello!

Thanks

@ovr ovr requested a review from a team as a code owner November 27, 2023 10:18
@ovr ovr changed the title refactor(schema-compiler): Migrate dialect to TypeScript refactor(schema-compiler): Migrate dialects to TypeScript Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 181 lines in your changes are missing coverage. Please review.

Comparison is base (2dcb9b9) 86.29% compared to head (6d49c02) 47.10%.
Report is 1 commits behind head on master.

Files Patch % Lines
...ubejs-schema-compiler/src/adapter/BigqueryQuery.ts 0.00% 26 Missing ⚠️
...ejs-schema-compiler/src/adapter/ClickHouseQuery.ts 0.00% 25 Missing ⚠️
...ubejs-schema-compiler/src/adapter/PrestodbQuery.ts 0.00% 19 Missing ⚠️
...es/cubejs-schema-compiler/src/adapter/HiveQuery.ts 0.00% 16 Missing ⚠️
.../cubejs-schema-compiler/src/adapter/OracleQuery.ts 0.00% 15 Missing ⚠️
...-schema-compiler/src/adapter/ElasticSearchQuery.ts 0.00% 13 Missing ⚠️
...s/cubejs-schema-compiler/src/adapter/MysqlQuery.ts 18.75% 13 Missing ⚠️
...hema-compiler/src/adapter/AWSElasticSearchQuery.ts 0.00% 12 Missing ⚠️
.../cubejs-schema-compiler/src/adapter/SqliteQuery.ts 0.00% 12 Missing ⚠️
...bejs-schema-compiler/src/adapter/SnowflakeQuery.ts 0.00% 10 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7462       +/-   ##
===========================================
- Coverage   86.29%   47.10%   -39.20%     
===========================================
  Files         174      155       -19     
  Lines       33656    20845    -12811     
  Branches        0     5369     +5369     
===========================================
- Hits        29045     9818    -19227     
- Misses       4611    10249     +5638     
- Partials        0      778      +778     
Flag Coverage Δ
cube-backend 47.10% <11.70%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovr ovr merged commit 5666c95 into master Nov 27, 2023
29 checks passed
@ovr ovr deleted the refactor/schema-compiler-dialect-ts branch November 27, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant