Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query-orchestrator): Improve code quality (more ts) #7505

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

ovr
Copy link
Member

@ovr ovr commented Dec 7, 2023

Hello!

Thanks

@ovr ovr requested a review from a team as a code owner December 7, 2023 23:11
Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 11:19pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 11:19pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 11:19pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 11:19pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 11:19pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 11:19pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 11:19pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 11:19pm

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (065916e) 86.29% compared to head (91f3d1a) 48.01%.
Report is 3 commits behind head on master.

Files Patch % Lines
...y-orchestrator/src/orchestrator/PreAggregations.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7505       +/-   ##
===========================================
- Coverage   86.29%   48.01%   -38.28%     
===========================================
  Files         174      154       -20     
  Lines       33820    20882    -12938     
  Branches        0     5371     +5371     
===========================================
- Hits        29185    10027    -19158     
- Misses       4635    10114     +5479     
- Partials        0      741      +741     
Flag Coverage Δ
cube-backend 48.01% <87.50%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovr ovr merged commit 03f0fdc into master Dec 8, 2023
35 of 39 checks passed
@ovr ovr deleted the refactory/query-orchestrator-more-ts branch December 8, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant