Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend-native): Fix request sequence span ids #9077

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jan 8, 2025

This fixes static request span id made from native to load api.

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon requested a review from a team as a code owner January 8, 2025 11:19
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.85%. Comparing base (f254f64) to head (07324e1).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9077   +/-   ##
=======================================
  Coverage   82.85%   82.85%           
=======================================
  Files         221      221           
  Lines       78813    78813           
=======================================
  Hits        65300    65300           
  Misses      13513    13513           
Flag Coverage Δ
cubesql 82.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@igorlukanin igorlukanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KSDaemon KSDaemon merged commit d48ef99 into master Jan 8, 2025
67 checks passed
@KSDaemon KSDaemon deleted the fix/span-seq branch January 8, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants