Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(databricks-driver): Enable Azure AD authentication via Client Secret #9104

Merged
merged 55 commits into from
Jan 23, 2025

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jan 16, 2025

This PR supersedes the original PR by @MaggieZhang-01 #6763, rebased on the latest master and resolves all the conflicts.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

In the Databricks driver, the credential is generated by the Azure storage account access key now which provides full access to the storage account. For security best practice, Microsoft recommends using authorization with Azure Active Directory.

This PR supports Azure AD authentication via service principal, providing more fine-grained control over access to storage resources.

Closes #6763

MaggieZhang-02 and others added 30 commits June 22, 2023 22:32
MaggieZhang-02 and others added 20 commits November 21, 2023 10:32
…-01/cube into MaggieZhang-01-add-azure-credential

# Conflicts:
#	packages/cubejs-backend-shared/src/env.ts
#	packages/cubejs-databricks-jdbc-driver/package.json
#	packages/cubejs-databricks-jdbc-driver/src/DatabricksDriver.ts
@KSDaemon KSDaemon marked this pull request as ready for review January 16, 2025 20:05
@KSDaemon KSDaemon requested review from a team as code owners January 16, 2025 20:05
@KSDaemon KSDaemon merged commit f121e4d into master Jan 23, 2025
47 checks passed
@KSDaemon KSDaemon deleted the MaggieZhang-01-add-azure-credential branch January 23, 2025 09:43
@igorlukanin
Copy link
Member

@MaggieZhang-01 This was released in v.1.1.17. Please feel free to check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants