Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Fix SELECT DISTINCT on pushdown #9144

Merged
merged 14 commits into from
Feb 12, 2025
+282 −5

some improvements

ef28dc7
Select commit
Loading
Failed to load commit list.
Merged

fix(cubesql): Fix SELECT DISTINCT on pushdown #9144

some improvements
ef28dc7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Feb 11, 2025 in 1s

98.47% of diff hit (target 83.34%)

View this Pull Request on Codecov

98.47% of diff hit (target 83.34%)

Annotations

Check warning on line 1536 in rust/cubesql/cubesql/src/compile/rewrite/rules/members.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/rewrite/rules/members.rs#L1536 

Added line #L1536 was not covered by tests

Check warning on line 1552 in rust/cubesql/cubesql/src/compile/rewrite/rules/members.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/rewrite/rules/members.rs#L1551-L1552 

Added lines #L1551 - L1552 were not covered by tests

Check warning on line 1567 in rust/cubesql/cubesql/src/compile/rewrite/rules/members.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/rewrite/rules/members.rs#L1567 

Added line #L1567 was not covered by tests
View more details on Codecov