Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Support complex join conditions for grouped joins #9157

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

[Description goes here]

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 97.98883% with 18 lines in your changes missing coverage. Please review.

Project coverage is 83.33%. Comparing base (9a73857) to head (db43682).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../cubesql/src/compile/rewrite/rules/wrapper/join.rs 97.60% 12 Missing ⚠️
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 57.14% 3 Missing ⚠️
...c/compile/rewrite/rules/wrapper/wrapper_pull_up.rs 95.31% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9157      +/-   ##
==========================================
+ Coverage   83.17%   83.33%   +0.15%     
==========================================
  Files         226      226              
  Lines       80096    80966     +870     
==========================================
+ Hits        66620    67470     +850     
- Misses      13476    13496      +20     
Flag Coverage Δ
cubesql 83.33% <97.98%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review January 29, 2025 18:51
@mcheshkov mcheshkov requested review from a team as code owners January 29, 2025 18:51
… issues

Expression like `(foo IS NOT NULL = bar IS NOT NULL)`` would try to compare `foo IS NOT NULL` with `bar`, not with `bar IS NOT NULL`
* Support COALESCE + IS NOT NULL join condition
* Support IS NOT DISTINCT join condition
* Support expression on top of columns, like CAST
@mcheshkov mcheshkov force-pushed the join-pushdown-complex-conditions branch from ae291e2 to db43682 Compare January 31, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant