Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Avoid panics during filter rewrites #9166

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#9164

@mcheshkov mcheshkov marked this pull request as ready for review January 31, 2025 13:47
@mcheshkov mcheshkov requested a review from a team as a code owner January 31, 2025 13:47
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 89.79592% with 10 lines in your changes missing coverage. Please review.

Project coverage is 83.35%. Comparing base (28c1e3b) to head (a8eea7c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...besql/cubesql/src/compile/rewrite/rules/filters.rs 66.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9166      +/-   ##
==========================================
+ Coverage   83.33%   83.35%   +0.01%     
==========================================
  Files         226      226              
  Lines       80966    81045      +79     
==========================================
+ Hits        67475    67552      +77     
- Misses      13491    13493       +2     
Flag Coverage Δ
cubesql 83.35% <89.79%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov merged commit 4c8de88 into master Feb 4, 2025
68 checks passed
@mcheshkov mcheshkov deleted the filter-null-panic branch February 4, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants