Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Support multiple columns in expression on each side in ungrouped-grouped join condition #9282

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

mcheshkov
Copy link
Member

@mcheshkov mcheshkov commented Feb 27, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Before this only expressions like CAST(left.dim AS TEXT) = CAST(right.col AS TEXT) were supported.
TopN over calculated fields can actually generate joins with calculated field in condition, so we have to support condition like CAST(left.dim1 AS TEXT) || CAST(left.dim2 AS TEXT) = CAST(right.col AS TEXT)

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 97.22222% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.75%. Comparing base (9ec4240) to head (6dbf52b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../cubesql/src/compile/rewrite/rules/wrapper/join.rs 90.90% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9282      +/-   ##
==========================================
+ Coverage   83.73%   83.75%   +0.01%     
==========================================
  Files         228      228              
  Lines       82249    82334      +85     
==========================================
+ Hits        68875    68961      +86     
+ Misses      13374    13373       -1     
Flag Coverage Δ
cubesql 83.75% <97.22%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcheshkov mcheshkov changed the title feat(cubesql): Support multiple columns on each side in ungrouped-grouped join condition feat(cubesql): Support multiple columns in expression on each side in ungrouped-grouped join condition Feb 27, 2025
@mcheshkov mcheshkov marked this pull request as ready for review February 27, 2025 13:42
@mcheshkov mcheshkov requested a review from a team as a code owner February 27, 2025 13:42
@mcheshkov mcheshkov force-pushed the grouped-join-multiple-columns branch from 2eb5bee to 6dbf52b Compare March 5, 2025 20:36
@mcheshkov mcheshkov merged commit e25d5c1 into master Mar 5, 2025
83 checks passed
@mcheshkov mcheshkov deleted the grouped-join-multiple-columns branch March 5, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants