Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow field injection of hooks in HiltObjectFactory #124

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

lsuski
Copy link
Contributor

@lsuski lsuski commented Dec 14, 2023

🤔 What's changed?

Previously hooks could be injected only in constructor in HiltObjectFactory which was not very handy for steps base class injection. This PR allows injecting hooks in fields

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)
  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@lsuski lsuski merged commit 5bfed16 into main Dec 14, 2023
1 check passed
@lsuski lsuski deleted the allow_field_injection_of_hooks_in_hilt branch December 14, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant