Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bill Payments #311

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Bill Payments #311

wants to merge 4 commits into from

Conversation

andreshndz
Copy link
Contributor

@andreshndz andreshndz commented Sep 9, 2022

This PR allows users and platforms to create BillPayments

import cuenca
from cuenca_validations.types import BillPaymentRequest
bill_payment_request = BillPaymentRequest(
    account_number='000000000000000000000000000000',
    amount=1000,
    provider_id='SP7e10ArgWaqNgSd9CM6VM7f',
    field_type='barcode',
)
cuenca.BillPayment.create(**bill_payment_request.dict())

@andreshndz andreshndz self-assigned this Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #311 (e431112) into main (8448740) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #311   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines         1025      1030    +5     
=========================================
+ Hits          1025      1030    +5     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cuenca/resources/users.py 100.00% <ø> (ø)
cuenca/resources/bill_payments.py 100.00% <100.00%> (ø)
cuenca/resources/service_providers.py 100.00% <100.00%> (ø)
cuenca/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8448740...e431112. Read the comment docs.

Copy link
Member

@alexviquez alexviquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solo la versión y un comment de la doc

user_id: Optional[str] = None,
) -> 'BillPayment':
"""
:param account_number: account id to be paid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

account number to be paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants