Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add click feedback to the previous and next question buttons #457

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

no-ov
Copy link
Contributor

@no-ov no-ov commented Mar 31, 2024

是不是上一题下一题加一个点击反馈更舒服些

@fengstats
Copy link
Collaborator

fengstats commented Mar 31, 2024

@no-ov 感谢贡献~ 不过 PR 与 commit 格式需要注意一下哦,参考 #91 (comment)

@no-ov
Copy link
Contributor Author

no-ov commented Mar 31, 2024

@no-ov 感谢贡献~ 不过 PR 与 commit 格式需要注意一下哦,参考 #91 (comment)

好的小石哥, 我下次注意按照格式来

@no-ov
Copy link
Contributor Author

no-ov commented Mar 31, 2024

rebase 重写了commit

  1. 点击反馈

@no-ov 感谢贡献~ 不过 PR 与 commit 格式需要注意一下哦,参考 #91 (comment)

@no-ov
Copy link
Contributor Author

no-ov commented Mar 31, 2024

default.mp4
default.mp4

@fengstats fengstats changed the title feat: 上一题下一题按钮点击反馈效果 feat: add click feedback to the previous and next question buttons Mar 31, 2024
@cuixiaorui cuixiaorui merged commit 1df45cf into cuixueshe:main Apr 1, 2024
1 check passed
cuixiaorui added a commit that referenced this pull request Apr 3, 2024
* feat: home upgrade v0.1 (unfinished)

* feat: add PayCard.vue

* feat: opt home page header style, separate component

* feat: separate components

* feat: opt home style

* fix: index.vue commit import and fix Navbar.vue h1 style

* fix: Navbar.vue button

* feat: PayCard style feat and fix some question

* feat: feat some style

* feat: feat PayCard style

* feat: feat Questions style

* fix: delete more svg

* feat: add next button (#413)

* feat: addNextButton

* feat: addChangeSkipSetting

* refactor: skip

---------

Co-authored-by: cuixiaorui <[email protected]>

* fix: Initialize the default shortcut key

* test: fix test case

* fix: rank Loading show position

* feat: jump to specific statement (#404)

* feat: to specific statement

* refactor: contents use virtual scroll

* feat: click contents outside then hide

* feat: save learned progress

* feat: content text line break

* refactor: change virtual scroll

* fix: unit test fetch history error

* feat: contents toogle mode

* refactor: contents on click outside

* refactor: detect whether the function is learned

---------

Co-authored-by: cuixiaorui <[email protected]>

* chore: use .node-version to fixed node version (#374)

* feat: Answer page support Space next sentence

* feat: add to back  previous statement (#425)

* feat: addPreviousButton

* fix: VariableValue

* refactor: delete message

* test: add test case for previous

---------

Co-authored-by: cuixiaorui <[email protected]>

* fix: prevent to the fix last incorrect word to the next Question page in Fix_Input mode

* refactor: merge the prev and next question hook

* fix: update bottom shortcuts tips style

* fix: add dropdown background (#438)

* feat: show tips when 3 times wrong (#440)

* fix: add dropdown background

* feat: show tips when 3 times wrong

* fix: hide AnswerTip after correctAnswer

* refactor: extraction function

---------

Co-authored-by: cuixiaorui <[email protected]>

* fix: change the style of the prev/next question btn on the game page (#434)

* fix: change the style of the prev/next question btn on the game page

* fix: Change the position of the Prev/Next question btn on the game page

* fix: Modify the style of the Previous/Next buttons

* fix: verify whether shortcut keys are duplicated (#394)

Co-authored-by: fengstats <[email protected]>

* fix: add typescript type checking to the handleEdit methd

* fix: modify the base  attribute to the typescript type

* test: modify some case for the test file

* test: add some expects

* fix: shortcutKey unit test

* fix: adjust home page and opt

* fix: optimize statement directory list style (#449)

Co-authored-by: fengstats <[email protected]>

* feat: home page last opt, add part func

* fix: clear input value and focus input when statementIndex is first

* fix: AnswerTip close correctly & always show close icon (#446)

* fix: close tip correctly

* feat: AnswerTip always show close icon

* refactor: close answer tips

---------

Co-authored-by: cuixiaorui <[email protected]>

* refactor: extraction function

* fix: optimize style of shortcut keys (#443)

Co-authored-by: fengstats <[email protected]>

* feat: show the course time and numbers on summary page (#312)

* feat: show the course time on the share page and summary page

* refactor: delete

* refactor: course time

---------

Co-authored-by: cuixiaorui <[email protected]>

* fix: adjust game page display (#456)

* fix: adjust game page display

* fix: zoom out AnswerTip width

* feat: add day style and fix some style

* fix: save the theme mode to localStorage (#468)

* style: update border color of rank item in dark mode (#467)

* test: add test cases for pronunciation (#464)

* feat: Add click feedback to the previous and next question buttons. (#457)

* fix: db upload error (#416)

* perf: convert to Chinese

* chore: update env example config & README file

* docs: update Testing description

* feat: Changed to Chinese, and added some daytime mode styles

* feat: add dictation mode

* refactor: move to components/home

* refactor:  remove commonBackTop on game page

* test: fix e2e test

---------

Co-authored-by: jiushi21 <[email protected]>
Co-authored-by: tors <[email protected]>
Co-authored-by: cuixiaorui <[email protected]>
Co-authored-by: fengstats <[email protected]>
Co-authored-by: ReinerLau <[email protected]>
Co-authored-by: BaboonKing <[email protected]>
Co-authored-by: nullcache <[email protected]>
Co-authored-by: 7ee <[email protected]>
Co-authored-by: Hazel <[email protected]>
Co-authored-by: vampirewy <[email protected]>
Co-authored-by: wendZzoo <[email protected]>
Co-authored-by: 小小石 <[email protected]>
Co-authored-by: Lee <[email protected]>
Co-authored-by: o_qll <[email protected]>
Co-authored-by: zwd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants