Replace fetchAll with fetchAllAssociative

cultuurnet · Jan 5, 2024 · b09c021 · b09c021
1 parent 082af95
commit b09c021
Show file tree

Hide file tree

Showing 12 changed files with 17 additions and 20 deletions.
diff --git a/app/Console/Command/ExcludeInvalidLabels.php b/app/Console/Command/ExcludeInvalidLabels.php
@@ -9,7 +9,6 @@
 use CultuurNet\UDB3\Model\ValueObject\Identity\UUID;
 use CultuurNet\UDB3\Model\ValueObject\Taxonomy\Label\LabelName;
 use Doctrine\DBAL\Connection;
-use PDO;
 use Symfony\Component\Console\Helper\ProgressBar;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
@@ -77,7 +76,7 @@ private function getAllLabelsCount(): int
                 ->where('excluded = :excluded')
                 ->setParameter(':excluded', 0)
                 ->execute()
-                ->fetchAll()
+                ->fetchAllAssociative()
         );
     }
 
@@ -91,6 +90,6 @@ private function getLabelsFromFirstResult(int $firstResult): array
             ->setFirstResult($firstResult)
             ->setMaxResults(self::MAX_RESULTS)
             ->execute()
-            ->fetchAll(PDO::FETCH_ASSOC);
+            ->fetchAllAssociative();
     }
 }
diff --git a/app/Console/Command/FindOutOfSyncProjections.php b/app/Console/Command/FindOutOfSyncProjections.php
@@ -79,7 +79,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             ->setParameter(':last_id', $input->getArgument('last-id'))
             ->groupBy('uuid')
             ->execute()
-            ->fetchAll();
+            ->fetchAllAssociative();
 
         foreach ($results as $result) {
             $uuid = $result['uuid'];

diff --git a/app/Console/Command/ReplaceNewsArticlePublisher.php b/app/Console/Command/ReplaceNewsArticlePublisher.php
@@ -83,7 +83,7 @@ private function getNewsArticleCount(string $publisher): int
                 ->where('publisher = :publisher')
                 ->setParameter(':publisher', $publisher)
                 ->execute()
-                ->fetchAll()
+                ->fetchAllAssociative()
         );
     }
 

diff --git a/app/Console/Command/UpdateUniqueLabels.php b/app/Console/Command/UpdateUniqueLabels.php
@@ -8,7 +8,6 @@
 use Doctrine\DBAL\Connection;
 use Doctrine\DBAL\DBALException;
 use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
-use PDO;
 use Ramsey\Uuid\Uuid;
 use Ramsey\Uuid\UuidInterface;
 use Symfony\Component\Console\Command\Command;
@@ -101,7 +100,7 @@ private function getAllLabelAddedEvents(int $offset): array
             ->setFirstResult($offset)
             ->setMaxResults(self::MAX_RESULTS)
             ->execute()
-            ->fetchAll(PDO::FETCH_ASSOC);
+            ->fetchAllAssociative();
     }
 
     private function getAllLabelAddedEventsCount(): int
@@ -113,7 +112,7 @@ private function getAllLabelAddedEventsCount(): int
                 ->where('type = "' . self::LABEL_CREATED . '"')
                 ->orderBy('id')
                 ->execute()
-                ->fetchAll()
+                ->fetchAllAssociative()
         );
     }
 

diff --git a/app/Console/Command/UpdateUniqueOrganizers.php b/app/Console/Command/UpdateUniqueOrganizers.php
@@ -114,7 +114,7 @@ private function getAllOrganizerEvents(int $offset): array
             ->setFirstResult($offset)
             ->setMaxResults(self::MAX_RESULTS)
             ->execute()
-            ->fetchAll(PDO::FETCH_ASSOC);
+            ->fetchAllAssociative();
     }
 
     private function getAllOrganizerEventsCount(): int
@@ -127,7 +127,7 @@ private function getAllOrganizerEventsCount(): int
                 ->orWhere('type = "' . self::ORGANIZER_WEBSITE_UPDATED . '"')
                 ->orderBy('id')
                 ->execute()
-                ->fetchAll()
+                ->fetchAllAssociative()
         );
     }
 

diff --git a/src/Contributor/DbalContributorRepository.php b/src/Contributor/DbalContributorRepository.php
@@ -51,7 +51,7 @@ public function isContributor(UUID $id, EmailAddress $emailAddress): bool
             ->setParameter(':id', $id->toString())
             ->setParameter(':email', $emailAddress->toString())
             ->execute()
-            ->fetchAll();
+            ->fetchAllAssociative();
 
         return count($results) > 0;
     }

diff --git a/src/Curators/DBALNewsArticleRepository.php b/src/Curators/DBALNewsArticleRepository.php
@@ -9,7 +9,6 @@
 use CultuurNet\UDB3\Model\ValueObject\Translation\Language;
 use CultuurNet\UDB3\Model\ValueObject\Web\Url;
 use Doctrine\DBAL\Connection;
-use Doctrine\DBAL\FetchMode;
 
 final class DBALNewsArticleRepository implements NewsArticleRepository
 {
@@ -30,7 +29,7 @@ public function getById(UUID $id): NewsArticle
             ->where('id = :id')
             ->setParameter(':id', $id->toString())
             ->execute()
-            ->fetchAll(FetchMode::ASSOCIATIVE);
+            ->fetchAllAssociative();
 
         if (count($newsArticleRows) !== 1) {
             throw new NewsArticleNotFound($id);
@@ -74,7 +73,7 @@ public function search(NewsArticleSearch $newsArticleSearch): NewsArticles
         $newsArticleRows = $query
             ->setMaxResults($newsArticleSearch->getItemsPerPage())
             ->execute()
-            ->fetchAll(FetchMode::ASSOCIATIVE);
+            ->fetchAllAssociative();
 
         return $this->createNewsArticles($newsArticleRows);
     }

diff --git a/src/Event/Productions/DBALProductionRepository.php b/src/Event/Productions/DBALProductionRepository.php
@@ -125,7 +125,7 @@ public function search(string $keyword, int $start, int $limit): array
             $query->setParameter(':keyword', $keyword);
         }
 
-        $results = $query->execute()->fetchAll();
+        $results = $query->execute()->fetchAllAssociative();
 
         if (empty($results)) {
             return [];
@@ -154,7 +154,7 @@ public function search(string $keyword, int $start, int $limit): array
     public function count(string $keyword): int
     {
         $keyword = $this->addWildcardToKeyword($keyword);
-        return count($this->createSearchQuery($keyword)->execute()->fetchAll());
+        return count($this->createSearchQuery($keyword)->execute()->fetchAllAssociative());
     }
 
     private function createSearchQuery(string $keyword): QueryBuilder

diff --git a/src/Event/ReadModel/Relations/Doctrine/DBALEventRelationsRepository.php b/src/Event/ReadModel/Relations/Doctrine/DBALEventRelationsRepository.php
@@ -117,7 +117,7 @@ private function eventHasRelations(
             ->setParameter('event_id', $id);
 
         $result = $q->execute();
-        $relations = $result->fetchAll();
+        $relations = $result->fetchAllAssociative();
 
         return count($relations) > 0;
     }

diff --git a/src/EventSourcing/DBAL/UniqueDBALEventStoreDecorator.php b/src/EventSourcing/DBAL/UniqueDBALEventStoreDecorator.php
@@ -159,7 +159,7 @@ private function executePreflightLookup(string $uniqueValue, string $domainMessa
             ->where($likeUniqueValue)
             ->setParameter('uniqueValue', $uniqueValue)
             ->execute()
-            ->fetchAll();
+            ->fetchAllAssociative();
 
         if (!empty($rows)) {
             throw new UniqueConstraintException(

diff --git a/src/Security/ResourceOwner/Doctrine/DBALResourceOwnerRepository.php b/src/Security/ResourceOwner/Doctrine/DBALResourceOwnerRepository.php
@@ -88,6 +88,6 @@ private function getResourceCount(string $resourceId): int
             ->where($this->idField . ' = :resource_id')
             ->setParameter(':resource_id', $resourceId)
             ->execute()
-            ->fetchAll());
+            ->fetchAllAssociative());
     }
 }
diff --git a/tests/Contributor/DbalContributorRepositoryTest.php b/tests/Contributor/DbalContributorRepositoryTest.php
@@ -157,7 +157,7 @@ public function it_can_overwrite_contributor_and_type(ItemType $itemType): void
             ->andWhere('type = :type')
             ->setParameter(':type', $itemType->toString())
             ->execute()
-            ->fetchAll();
+            ->fetchAllAssociative();
 
         $this->assertEquals(2, count($result));
     }