Bugfix/III-4855 Enforce max limit on /labels endpoint #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an api context we wish to return a max of 30 results, but that's not necessarily the case in other contexts (eg. CLI command)
steftrenson
requested review from
LucWollants,
JonasVHG,
simon-debruijn and
grubolsch
as code owners
simon-debruijn
approved these changes
Feb 20, 2025
LucWollants
approved these changes
Feb 20, 2025
JonasVHG
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
/labelsendpoint without start and limit will now use sensible defaults./labelsendpoint with a high limit will reduce this to 30 so that DOS attacks are less likely.Ticket: https://jira.publiq.be/browse/III-4855