fix: filter irrelevant options from jest configuration

currents-dev · Jul 24, 2024 · 77c1aac · 77c1aac
1 parent a8d3686
commit 77c1aac
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 12 deletions.
diff --git a/packages/cmd/src/discovery/jest/args/args.ts b/packages/cmd/src/discovery/jest/args/args.ts
@@ -3,7 +3,6 @@ import { omit } from "lodash";
 const ignoredOptions = [
   "bail", // causes unexpected behaviour
   "clearCache",
-  "clearMocks",
   "collectCoverage",
   "collectCoverageFrom",
   "color",
@@ -29,7 +28,6 @@ const ignoredOptions = [
   "notifyMode",
   "openHandlesTimeout",
   "outputFile",
-  "prettierPath",
   "reporters",
   "runner",
   "shard",

diff --git a/packages/cmd/src/discovery/jest/args/config.ts b/packages/cmd/src/discovery/jest/args/config.ts
@@ -17,29 +17,77 @@ export async function getConfigFilePath(
       explicitConfigFilePath
     );
 
-    const parsedConfigObject = omit(initialConfig, [
+    const configOptionsToAvoid = [
+      // from docs: https://jestjs.io/docs/configuration
       "collectCoverage",
       "collectCoverageFrom",
       "coverageDirectory",
       "coveragePathIgnorePatterns",
       "coverageProvider",
       "coverageReporters",
       "coverageThreshold",
+      "errorOnDeprecated",
+      "forceCoverageMatch",
+      "notify",
+      "notifyMode",
+      "openHandlesTimeout",
+      "reporters",
+      "runner",
+      "showSeed",
+      "testFailureExitCode",
+      "verbose",
+      "watchPathIgnorePatterns",
+      "watchPlugins",
+      "watchman",
+
+      // from Config type
+      "bail", // causes unexpected behaviour
+      "clearCache",
+      "color",
+      "colors",
+      "debug",
       "detectLeaks",
       "detectOpenHandles",
-      "reporters",
-      "logHeapUsage",
+      "expand",
+      "forceExit",
+      "json",
       "listTests",
-      "notify",
-      "notifyMode",
+      "logHeapUsage",
+      "noStackTrace",
+      "outputFile",
+      "shard",
+      "showConfig",
       "silent",
-      "verbose",
+      "testNamePattern",
+      "waitNextEventLoopTurnForUnhandledRejectionEvents",
       "watch",
       "watchAll",
-      "watchman",
-      "watchPlugins",
-      "shard",
-    ]);
+    ];
+
+    // from InitialProjectOptions type
+    const projectConfigOptionsToAvoid = [
+      "collectCoverageFrom",
+      "coverageDirectory",
+      "coveragePathIgnorePatterns",
+      "detectLeaks",
+      "detectOpenHandles",
+      "errorOnDeprecated",
+      "forceCoverageMatch",
+      "openHandlesTimeout",
+      "runner",
+      "watchPathIgnorePatterns",
+    ];
+
+    const parsedConfigObject = omit(initialConfig, configOptionsToAvoid);
+
+    if (parsedConfigObject.projects) {
+      parsedConfigObject.projects = parsedConfigObject.projects.map(
+        (project) =>
+          typeof project !== "string"
+            ? omit(project, projectConfigOptionsToAvoid)
+            : project
+      );
+    }
 
     if (
       parsedConfigObject.rootDir &&