Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSR-2066] feat: get full test suite from JSON file #138

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

miguelangaranocurrents
Copy link
Contributor

@miguelangaranocurrents miguelangaranocurrents commented Jan 22, 2025

Description

Provide a brief description of the changes in this PR. Important to list all the changes made in overall. Describe any improvements, follow up tasks or edge cases related to this PR

This PR removes the full test suite creation in the upload command for the JUnit scanner. It will only read a JSON file with the full test suite.

PR Checklist

  • I performed manual tests or added tests that prove my fix is effective or that my feature works.
  • I have performed a self-review of my code.
  • I have annotated my PR with comments, particularly in hard-to-understand areas.
  • I have considered the security implications of this work.

Release Plan

Do we need to update any environment variables? Is there any order of releases required?

  • Package release

Demo

Add screenshots or videos demonstrating the solution if applicable

https://www.loom.com/share/6e9720910f224ff68cb93863f09659bb?sid=97690a7b-93e5-4e30-a99b-dea791962c77

Manual Testing

Describe in steps (support it with images if needed) how to try the changes of this PR. (Even the start/setup of the services needed to try it out). If it's a bug also include reproduction steps

  1. Use the convert command to create instance files
  2. Paste in the results folder the full test suite related to those results
  3. Use the upload command

Copy link

@miguelangaranocurrents miguelangaranocurrents requested review from twk3 and removed request for twk3 January 24, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants