Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSR-1645] fix: Rename from --paths to --path #16

Merged
merged 1 commit into from
Oct 2, 2024
Merged

[CSR-1645] fix: Rename from --paths to --path #16

merged 1 commit into from
Oct 2, 2024

Conversation

vCaisim
Copy link
Collaborator

@vCaisim vCaisim commented Oct 2, 2024 •
edited
Loading

  • verify workflow examples
    • GHA workflows does not use --path
    • GitLab pipelines does not use --path
  • update GHA template
    • renamed template option from paths to path, v1.0.7
  • test the action template after update

@notion-workspace Notion Workspace
Copy link

🐞 Rename from —paths to —path

@vCaisim vCaisim requested a review from twk3 October 2, 2024 10:16
twk3
twk3 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@twk3 twk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the change is working as expected by building and running the command with multiple path calls, and checking that the --help flag showed the updates.

@twk3 twk3 merged commit 34f8ec7 into main Oct 2, 2024
2 checks passed
@twk3 twk3 deleted the fix/rename-path-cli-param branch October 2, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twk3 twk3 twk3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vCaisim @twk3