chore: ..

currents-dev · Sep 17, 2023 · f32a1d5 · f32a1d5
1 parent afb690a
commit f32a1d5
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 42 deletions.
diff --git a/packages/cypress-cloud/lib/results/__tests__/mapResults.test.ts b/packages/cypress-cloud/lib/results/__tests__/mapResults.test.ts
@@ -1,8 +1,4 @@
-import {
-  getInstanceResultPayload,
-  getInstanceTestsPayload,
-  getTestAttempt,
-} from "../api";
+import { getInstanceResultPayload, getInstanceTestsPayload } from "../api";
 import configException from "./fixtures/payloads/cypressResult/exception/config.json";
 import rawResultException from "./fixtures/payloads/cypressResult/exception/results.json";
 

diff --git a/packages/cypress-cloud/lib/results/empty.ts b/packages/cypress-cloud/lib/results/empty.ts
@@ -1,40 +1,6 @@
 import { Standard } from "../cypress.types";
 import { ConfigState } from "../state";
 
-/**
- * Generates a fake test item from an exception
- *
- * @param error
- * @param stats
- * @returns
- */
-export function getFakeTestFromException(
-  error: string,
-  stats: Standard.ModuleAPI.Run["stats"]
-): Standard.ModuleAPI.Test {
-  return {
-    title: ["Unknown"],
-    body: "",
-    displayError: error.split("\n")[0],
-    state: "failed",
-    attempts: [
-      {
-        state: "failed",
-        duration: 0,
-        error: {
-          name: "Error",
-          message: error.split("\n")[0],
-          stack: error,
-          codeFrame: null,
-        },
-        screenshots: [],
-        startedAt: stats.startedAt,
-        videoTimestamp: 0,
-      },
-    ],
-  };
-}
-
 export const emptyStats = {
   totalDuration: 0,
   totalSuites: 0,
@@ -45,7 +11,10 @@ export const emptyStats = {
   totalTests: 0,
 };
 
-const getDummyFailedTest = (start: string, error: string) => ({
+const getDummyFailedTest = (
+  start: string,
+  error: string
+): Standard.ModuleAPI.Test => ({
   title: ["Unknown"],
   state: "failed",
   body: "// This test is automatically generated due to execution failure",

diff --git a/packages/cypress-cloud/lib/results/mapResult.ts b/packages/cypress-cloud/lib/results/mapResult.ts
@@ -4,7 +4,6 @@
 
 import { Standard } from "../cypress.types";
 import { ConfigState } from "../state";
-import { getFakeTestFromException } from "./empty";
 
 export class SpecAfterToModuleAPIMapper {
   static getTestAttempt(
@@ -106,3 +105,37 @@ export class SpecAfterToModuleAPIMapper {
     };
   }
 }
+
+/**
+ * Generates a fake test item from an exception
+ *
+ * @param error
+ * @param stats
+ * @returns
+ */
+function getFakeTestFromException(
+  error: string,
+  stats: Standard.ModuleAPI.Run["stats"]
+): Standard.ModuleAPI.Test {
+  return {
+    title: ["Unknown"],
+    body: "",
+    displayError: error.split("\n")[0],
+    state: "failed",
+    attempts: [
+      {
+        state: "failed",
+        duration: 0,
+        error: {
+          name: "Error",
+          message: error.split("\n")[0],
+          stack: error,
+          codeFrame: null,
+        },
+        screenshots: [],
+        startedAt: stats.startedAt,
+        videoTimestamp: 0,
+      },
+    ],
+  };
+}
diff --git a/packages/cypress-cloud/lib/state/execution.ts b/packages/cypress-cloud/lib/state/execution.ts
@@ -157,7 +157,7 @@ export class ExecutionState {
 
       return getFailedFakeInstanceResult(configState, {
         specs: ["unknown"],
-        error: "Cannot find execution state for instance",
+        error: `[currents] Error while processing cypress results for instance ${instanceId}. See the console output for details.`,
       });
     }