fix type

currents-dev · Jan 10, 2024 · 246b48e · 246b48e
1 parent bdd028b
commit 246b48e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/cypress-cloud/lib/api/types/run.ts b/packages/cypress-cloud/lib/api/types/run.ts
@@ -1,5 +1,6 @@
 import { CiParams, CiProvider } from "cypress-cloud/lib/ciProvider";
 import { Platform, ValidatedCurrentsParameters } from "cypress-cloud/types";
+import { GhaEventData } from "../../git";
 
 export type CreateRunPayload = {
   ci: {
@@ -10,7 +11,7 @@ export type CreateRunPayload = {
   projectId: string;
   recordKey: string;
   commit: {
-    [memoKey: string]: string | null;
+    [memoKey: string]: string | GhaEventData | null;
   };
   specs: string[];
   group?: string;

diff --git a/packages/cypress-cloud/lib/ciProvider.ts b/packages/cypress-cloud/lib/ciProvider.ts
@@ -742,11 +742,14 @@ export function getCommitDefaults(existingInfo: CiProviderData) {
   const combined = _.transform(
     existingInfo,
     (
-      memo: { [memoKey: string]: string | null },
+      memo: { [memoKey: string]: string | GhaEventData | null },
       value: string | GhaEventData,
       key: string
     ) => {
-      return (memo[key] = _.defaultTo(value || commitParamsObj[key], null));
+      return (memo[key] = _.defaultTo(
+        value || commitParamsObj[key as keyof CiProvider],
+        null
+      ));
     }
   );