refactor: convert ConnectWalletPrompt to mui #619
+165
−207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
OnlyJousting
approved these changes
Jan 23, 2025
DanielSchiavini
force-pushed
the
refactor/wallet-connect-mui
branch
from
ff0c894 to
31edeb7
Compare
OnlyJousting
approved these changes
Jan 23, 2025
0xAlunara
requested changes
Jan 23, 2025
| onClick={connectWallet} | ||
| loading={isLoading} | ||
| loadingPosition="start" | ||
| data-testid={`btn-connect-prompt${isLoading ? '-loading' : ''}`} |
There was a problem hiding this comment.
I suppose you wanted to test this with cypress but forgot?
| spacing={3} | ||
| > | ||
| <CurveLogo src={LogoImg} alt="Curve Logo" /> | ||
| <Typography variant="headingXxl">Enter Curve</Typography> |
| padding={7} | ||
| sx={{ | ||
| backgroundColor: 'var(--table--background-color)', | ||
| maxWidth: '50rem', |
There was a problem hiding this comment.
I know it's based on the old component but imo we should get rid of the magic numbers and use design system sizes and spaces
| }} | ||
| > | ||
| <Box display="flex" position="relative" width="100%"> | ||
| <Box |
There was a problem hiding this comment.
I think we can get rid of this Box and just use a (non-absolute-positioned) Stack with
sx={{
backgroundImage: `url(${getBackgroundUrl(useUserProfileStore((state) => state.theme))})`,
backgroundSize: 'contain',
backgroundPosition: 'center',
backgroundRepeat: 'no-repeat',
}}
| <Typography variant="headingXxl">Enter Curve</Typography> | ||
| </Stack> | ||
| </Box> | ||
| <Stack gap={3} alignItems="center" width="100%" margin="0 auto"> |
There was a problem hiding this comment.
width="100%" margin="0 auto" can be removed
| <Stack | ||
| position="absolute" | ||
| alignItems="center" | ||
| width="100%" |
| maxWidth: '50rem', | ||
| }} | ||
| > | ||
| <Box display="flex" position="relative" width="100%"> |
There was a problem hiding this comment.
width="100%" can be removed I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
var(--table--background-color)for now as that's white for chadloadingprop mui/material-ui#44637