Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fake tasks #19

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Remove fake tasks #19

merged 2 commits into from
Mar 13, 2024

Conversation

Peechiz
Copy link
Contributor

@Peechiz Peechiz commented Mar 12, 2024

Stakeholder Overview (learn more)

Unchecked risk categories are not unfinished "tasks", but github parses them as such. This also conflicts with PRs that wish to use the task feature to keep track of features within a PR. This would change the format to a list and encourage people to use appropriate emoji instead for readability.

Risk Estimate (learn more)

This is an example of what usage might look like, and also an accurate risk estimate of the PR. (risk is super low, but it does affect every repo.)

  • ✅ Big splash zone
  • ✅ Negligible risk

@Peechiz Peechiz requested a review from a team as a code owner March 12, 2024 16:19
@Peechiz Peechiz requested review from chmurph2 and invacuo and removed request for a team March 12, 2024 16:19
Copy link
Contributor

@paulslaby paulslaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea. Please change it accordingly in the linked guru card too.

@jurahu
Copy link

jurahu commented Mar 12, 2024

❤️‍🔥 YES!

@Peechiz
Copy link
Contributor Author

Peechiz commented Mar 12, 2024

Please change it accordingly in the linked guru card too.

done

@a-maas
Copy link

a-maas commented Mar 12, 2024

Just throwing out an alternate: What if the instruction were to review the list and remove any that were not risks and only keep risks that apply to your change?

Copy link
Member

@chmurph2 chmurph2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, and LGTM

@paulslaby paulslaby merged commit ff22213 into master Mar 13, 2024
@metaskills
Copy link
Contributor

Reminder this is a PUBLIC repo.

@paulslaby paulslaby deleted the risk-estimate-emoji branch March 13, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants